Date: Sun, 29 Aug 2010 20:18:06 +0000 (UTC) From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/cddl/contrib/opensolaris/lib/pyzfs/common ioctl.c Message-ID: <201008292018.o7TKIPXV033740@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
pjd 2010-08-29 20:18:06 UTC
FreeBSD src repository
Modified files:
cddl/contrib/opensolaris/lib/pyzfs/common ioctl.c
Log:
SVN rev 211970 on 2010-08-29 20:18:06Z by pjd
Fix 'zfs allow' (maybe not only) returning:
cannot access dataset system/usr/home: Operation not supported
by including libzfs_impl.h. What libzfs_impl.h does is to redefine ioctl() to
be compatible with OpenSolaris. More specifically OpenSolaris returns ENOMEM
when buffer is too small and sets field zc_nvlist_dst_size to the size that
will be big enough for the data. In FreeBSD case ioctl() doesn't copy data
structure back in case of a failure. We work-around it in kernel and libzfs by
returning 0 from ioctl() and always checking if zc_nvlist_dst_size hasn't
changed. For this work-around to work in pyzfs we need this compatible ioctl()
which is implemented in libzfs_impl.h.
MFC after: 2 weeks
Revision Changes Path
1.2 +1 -0 src/cddl/contrib/opensolaris/lib/pyzfs/common/ioctl.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008292018.o7TKIPXV033740>