Date: Tue, 22 Nov 2005 11:48:55 -0300 From: Alejandro Pulver <alejandro@varnet.biz> To: freebsd-ports@freebsd.org Subject: Re: bsd.wx.mk Message-ID: <20051122114855.5970964f@phobos.mars.bsd> In-Reply-To: <20051121212519.GA7444@xor.obsecurity.org> References: <20051121163721.60580f01@phobos.mars.bsd> <20051121211004.GA15250@soaustin.net> <20051121232023.5ed476db@it.buh.tecnik93.com> <20051121212519.GA7444@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 21 Nov 2005 16:25:20 -0500 Kris Kennaway <kris@obsecurity.org> wrote: > On Mon, Nov 21, 2005 at 11:20:23PM +0200, Ion-Mihai Tetcu wrote: > > On Mon, 21 Nov 2005 15:10:04 -0600 > > linimon@lonesome.com (Mark Linimon) wrote: > > > > > > .warning "FreeBSD versions prior to 5.x do not support > > > > Unicode" > > > > > > Some of them don't support .warning, either :-) > > > I have removed it. > > > Other than that it looks pretty good. My only concern is with a > > > few short variable names (_UC) that might conflict with names > > > used in ports themselves? Perhaps I'm just being paranoid. > > > > Or perhaps we need something like KNOBS with reserved words ? > > That would be too complicated. System components like bsd.*.mk should > just stay away from simple variable names that might be used > elsewhere. > > Kris > I changed it into _WXUC and _WXUCL (now all internal variables start with _WX). I have uploaded a new version. Thanks to all of you for your suggestions. Best Regards, Ale
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051122114855.5970964f>