Date: Thu, 22 Jan 2015 09:49:13 -0700 From: Ian Lepore <ian@freebsd.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, gibbs@FreeBSD.org, src-committers <src-committers@freebsd.org>, Will Andrews <will@FreeBSD.org> Subject: Re: svn commit: r277511 - head/sys/dev/firewire Message-ID: <1421945353.14601.402.camel@freebsd.org> In-Reply-To: <D23E70CE-2741-4321-BDCB-DB2F5BF7DE19@FreeBSD.org> References: <201501212008.t0LK8PhR001309@svn.freebsd.org> <D23E70CE-2741-4321-BDCB-DB2F5BF7DE19@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2015-01-22 at 16:26 +0000, Bjoern A. Zeeb wrote: > > On 21 Jan 2015, at 20:08 , Will Andrews <will@FreeBSD.org> wrote: > > > > Author: will > > Date: Wed Jan 21 20:08:24 2015 > > New Revision: 277511 > > URL: https://svnweb.freebsd.org/changeset/base/277511 > > > > Log: > > Fix remote DMA based firewire debugging when targeting > > systems with more than 4GB of physical memory. > > > > To remotely debug the system 'stealthy' which has a kernel > > with this change installed and firewire properly configured: > > > > % fwcontrol -m stealthy (or stealthy's firewire EUI64) > > % kgdb kernel /dev/fwmem0.0 > > > > sys/dev/firewire/fwohci.c: > > Rather than hard code the upper limit for hw based > > automatic responses to remote DMA requests at 4GB, > > program the hardware using Maxmem, the page number > > one higher than the highest physical page detected > > in the system. > > > > While here, garbage collect more useless splfw() > > calls. > > > > Submitted by: gibbs > > MFC after: 1 week > > Sponsored by: Spectra Logic > > MFSpectraBSD: 1110994 on 2015/01/06 > > arm doesnąt define a Maxmem; the kernel builds are thus currently broken. > > converting beaglebone.dts -> /storage/head/obj/arm.armv6/scratch/tmp/bz/head.svn/sys/BEAGLEBONE/beaglebone.dtb > /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1856:28: error: use of undeclared identifier 'Maxmem' > prequpper = ((uintmax_t)Maxmem << PAGE_SHIFT) >> 16; > ^ > /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1862:20: error: use of undeclared identifier 'Maxmem' > (uintmax_t)Maxmem << PAGE_SHIFT, > ^ > 2 errors generated. This is the first I've heard of Maxmem. I think I can get it added to arm pretty quickly. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1421945353.14601.402.camel>