Date: Tue, 13 Aug 2013 16:19:37 +1000 (EST) From: John Marshall <john.marshall@riverwillow.com.au> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11 Message-ID: <201308130619.r7D6Jbxb018744@rwsrv08.mby.riverwillow.net.au> Resent-Message-ID: <201308130640.r7D6e12b028273@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181248 >Category: ports >Synopsis: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 13 06:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marshall >Release: FreeBSD 9.2-RC1 amd64 >Organization: Riverwillow Pty Ltd >Environment: System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.2-RC1 FreeBSD 9.2-RC1 #0 r254103: Fri Aug 9 09:30:29 AEST 2013 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64 >Description: r324269 introduced INSTALLS_ICONS to the Makefile. This has the wonderful side-effect of pulling in the entire GNOME toolchain on a server. How about wrapping this baby in a conditional blanket so that more server admin's don't have to spend ages trying to figure out what pulled in all those GUI ports? >How-To-Repeat: cd /usr/ports/print/cups-base make depends >Fix: Neither r324269 (which introduced INSTALLS_ICONS) nor r324428 (which moved its location) bumped PORTREVISION, so this patch doesn't either. --- cups-base_324646.diff begins here --- Index: print/cups-base/Makefile =================================================================== --- print/cups-base/Makefile (revision 324646) +++ print/cups-base/Makefile (working copy) @@ -67,7 +67,9 @@ LICENSE= LGPL21 OPTIONS_DEFINE= GNUTLS .else +.if !defined(WITHOUT_X11) INSTALLS_ICONS= yes +.endif PORTREVISION= 1 CUPS_SUFFIX= -base OPTIONS_DEFINE= GNUTLS LIBPAPER PHP PYTHON PAM LDAP DBUS LIBUSB XDG_OPEN GHOSTSCRIPT XPDF AVAHI MDNSRESPONDER --- cups-base_324646.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308130619.r7D6Jbxb018744>