Date: Sat, 13 Mar 2004 16:05:13 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/py-gtk2 Makefile Message-ID: <20040314000513.GB65109@xor.obsecurity.org> In-Reply-To: <200403131801.i2DI1Xqn098604@repoman.freebsd.org> References: <200403131801.i2DI1Xqn098604@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--JYK4vJDZwFMowpUq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Mar 13, 2004 at 10:01:33AM -0800, Joe Marcus Clarke wrote:
> marcus 2004/03/13 10:01:33 PST
>=20
> FreeBSD ports repository
>=20
> Modified files:
> x11-toolkits/py-gtk2 Makefile=20
> Log:
> Correct a typo that prevented thread support from being enabled.
> =20
> Submitted by: Davide D'Amico <dave@civetta.gufi.org>
Why is this necessary?
> | -LIBC_R!=3D /sbin/ldconfig -r | grep "c_r|pthread" || true
> | +LIBC_R!=3D /sbin/ldconfig -r | grep "c_r\|pthread" || true
> | .if (${LIBC_R} !=3D "") && !defined(WITHOUT_THREADS)
> | CONFIGURE_ARGS+=3D --enable-thread
> | CFLAGS+=3D ${PTHREAD_CFLAGS}
By default, every FreeBSD platform supports threads in one form or
another (but via the same interface, PTHREAD_{CFLAGS,LIBS}) -- your
test omits testing for libthr, by the way. The only way someone will
have arrived at a system without threads is if they have disabled it
with make.conf variables, so can't you just test for those if you want
to support those systems?
Kris
--JYK4vJDZwFMowpUq
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAU6G5Wry0BWjoQKURAnfRAKDgeK/PvKovqYmGXazfY4cRYlUaRACgnrHU
KiTXUq3BhMhiEFIeDWaDPdE=
=ZioY
-----END PGP SIGNATURE-----
--JYK4vJDZwFMowpUq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040314000513.GB65109>