Date: Tue, 6 Feb 2018 15:08:12 -0800 From: Dexuan-BSD Cui <dexuan.bsd@gmail.com> To: Mike Tancsa <mike@sentex.net>, decui@microsoft.com Cc: Kirk McKusick <mckusick@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r328944 - stable/11/sys/kern Message-ID: <CABkgQk_uhSkYL4NOaVTebfE%2B_Y%2B4zsnmDR5SsqF4HQwG8Hy9wA@mail.gmail.com> In-Reply-To: <3c1f7e72-364b-f08a-7b25-d2e7177b41c2@sentex.net> References: <201802061913.w16JDiP8047547@repo.freebsd.org> <3c1f7e72-364b-f08a-7b25-d2e7177b41c2@sentex.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm getting the error too:
/root/freebsd/sys/kern/vfs_subr.c:3368:30: error: no member named
'v_unpcb' in 'struct vnode'
printf(" socket %p\n", vp->v_unpcb);
On Tue, Feb 6, 2018 at 1:42 PM, Mike Tancsa <mike@sentex.net> wrote:
> On 2/6/2018 2:13 PM, Kirk McKusick wrote:
>> Author: mckusick
>> Date: Tue Feb 6 19:13:44 2018
>> New Revision: 328944
>> URL: https://svnweb.freebsd.org/changeset/base/328944
>>
>> Log:
>> MFC of 328643.
>>
>> fix vn_printf listing of its union
>
> Hi,
> I am getting a buildfailure with this commit, I think
>
> --------------------------------------------------------------
>>>> stage 3.1: building everything
> --------------------------------------------------------------
> cd /usr/obj/usr/src/sys/server; COMPILER_VERSION=50001
> COMPILER_FEATURES=c++11 COMPILER_TYPE=clang
> COMPILER_FREEBSD_VERSION=1100505 MAKEOBJDIRPREFIX=/usr/obj
> MACHINE_ARCH=amd64 MACHINE=amd64 CPUTYPE=
> GROFF_BIN_PATH=/usr/obj/usr/src/tmp/legacy/usr/bin
> GROFF_FONT_PATH=/usr/obj/usr/src/tmp/legacy/usr/share/groff_font
> GROFF_TMAC_PATH=/usr/obj/usr/src/tmp/legacy/usr/share/tmac CC="cc
> -target x86_64-unknown-freebsd11.1 --sysroot=/usr/obj/usr/src/tmp
> -B/usr/obj/usr/src/tmp/usr/bin" CXX="c++ -target
> x86_64-unknown-freebsd11.1 --sysroot=/usr/obj/usr/src/tmp
> -B/usr/obj/usr/src/tmp/usr/bin" CPP="cpp -target
> x86_64-unknown-freebsd11.1 --sysroot=/usr/obj/usr/src/tmp
> -B/usr/obj/usr/src/tmp/usr/bin" AS="as" AR="ar" LD="ld" NM=nm
> OBJDUMP=objdump OBJCOPY="objcopy" RANLIB=ranlib STRINGS= SIZE="size"
> INSTALL="sh /usr/src/tools/install.sh"
> PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin
> make -D NO_KERNELCLEAN -m /usr/src/share/mk KERNEL=kernel all
> -DNO_MODULES_OBJ
> cc -target x86_64-unknown-freebsd11.1 --sysroot=/usr/obj/usr/src/tmp
> -B/usr/obj/usr/src/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasing -g
> -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL
> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h
> -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD
> -MF.depend.vfs_subr.o -MTvfs_subr.o -mcmodel=kernel -mno-red-zone
> -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables
> -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__
> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
> -Wno-error-tautological-compare -Wno-error-empty-body
> -Wno-error-parentheses-equality -Wno-error-unused-function
> -Wno-error-pointer-sign -Wno-error-shift-negative-value
> -Wno-error-address-of-packed-member -mno-aes -mno-avx
> -std=iso9899:1999 -Werror /usr/src/sys/kern/vfs_subr.c
> /usr/src/sys/kern/vfs_subr.c:3368:30: error: no member named 'v_unpcb'
> in 'struct vnode'
> printf(" socket %p\n", vp->v_unpcb);
> ~~ ^
> 1 error generated.
> *** Error code 1
>
> Stop.
> make[2]: stopped in /usr/obj/usr/src/sys/server
> *** Error code 1
>
> Stop.
> make[1]: stopped in /usr/src
> *** Error code 1
>
> Stop.
>
>
>>
>> Modified:
>> stable/11/sys/kern/vfs_subr.c
>> Directory Properties:
>> stable/11/ (props changed)
>>
>> Modified: stable/11/sys/kern/vfs_subr.c
>> ==============================================================================
>> --- stable/11/sys/kern/vfs_subr.c Tue Feb 6 19:09:49 2018 (r328943)
>> +++ stable/11/sys/kern/vfs_subr.c Tue Feb 6 19:13:44 2018 (r328944)
>> @@ -3355,8 +3355,25 @@ vn_printf(struct vnode *vp, const char *fmt, ...)
>> va_end(ap);
>> printf("%p: ", (void *)vp);
>> printf("tag %s, type %s\n", vp->v_tag, typename[vp->v_type]);
>> - printf(" usecount %d, writecount %d, refcount %d mountedhere %p\n",
>> - vp->v_usecount, vp->v_writecount, vp->v_holdcnt, vp->v_mountedhere);
>> + printf(" usecount %d, writecount %d, refcount %d",
>> + vp->v_usecount, vp->v_writecount, vp->v_holdcnt);
>> + switch (vp->v_type) {
>> + case VDIR:
>> + printf(" mountedhere %p\n", vp->v_mountedhere);
>> + break;
>> + case VCHR:
>> + printf(" rdev %p\n", vp->v_rdev);
>> + break;
>> + case VSOCK:
>> + printf(" socket %p\n", vp->v_unpcb);
>> + break;
>> + case VFIFO:
>> + printf(" fifoinfo %p\n", vp->v_fifoinfo);
>> + break;
>> + default:
>> + printf("\n");
>> + break;
>> + }
>> buf[0] = '\0';
>> buf[1] = '\0';
>> if (vp->v_vflag & VV_ROOT)
>> _______________________________________________
>> svn-src-stable-11@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11
>> To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org"
>>
>>
>
>
> --
> -------------------
> Mike Tancsa, tel +1 519 651 3400 x203
> Sentex Communications, mike@sentex.net
> Providing Internet services since 1994 www.sentex.net
> Cambridge, Ontario Canada
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABkgQk_uhSkYL4NOaVTebfE%2B_Y%2B4zsnmDR5SsqF4HQwG8Hy9wA>