Date: Wed, 11 Apr 2018 20:02:08 -0400 From: Eric McCorkle <eric@metricspace.net> To: Warner Losh <imp@bsdimp.com>, Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Tommi Pernila <tommi.pernila@iki.fi>, "[ScaleEngine] Allan Jude" <allan.jude@scaleengine.com>, freebsd-current <freebsd-current@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? Message-ID: <c0c57711-055a-5d0d-796e-f7acce4be3b4@metricspace.net> In-Reply-To: <CANCZdfqZ1qr0Z7eiby6Kvwop_-%2B3_VZ0hFnCfo7Hm1NN9UbaUA@mail.gmail.com> References: <CABHD1wRyrmXp5R_ViERa-MnJnVKN-U551SWt%2Behm6r%2B3viydxg@mail.gmail.com> <CANCZdfp-bYi2fFJi5ashPLwjnwKWeoepiPt23LfPORU1EpKNGg@mail.gmail.com> <CABHD1wQU_6wHw96%2BLguVuqmwqY04%2Bn7NPcy6rSgn4QdKZpF3Kg@mail.gmail.com> <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <CABHD1wS-RoxP5fsCYgH61BsPsad_OPC4FZSUCUi6EfsWyXRzQA@mail.gmail.com> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> <f17bbb44-6735-e252-ba75-bd0b4f685d9d@metricspace.net> <CABHD1wRu_C4dPvzt%2BxMsYYYjFNJ1%2B78ne4cLsuCxr=YrN%2BhfFA@mail.gmail.com> <CANCZdfrkW1yteAixk44DetDe=uetVtvxM9-M7K5FioxeLseHJw@mail.gmail.com> <D667242D-ACB8-42E4-85B8-308702C15360@metricspace.net> <CAPQ4fftB27Y63yvk9zqEE3q4-MShHOYdwM7aD=c%2BXKzrs%2BZoMw@mail.gmail.com> <CANCZdfqZ1qr0Z7eiby6Kvwop_-%2B3_VZ0hFnCfo7Hm1NN9UbaUA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j6rsGUR5EYtrs6ssNwWRg2jQQpYzSHXaK Content-Type: multipart/mixed; boundary="ztiM6EPjGKnm5abadnKD9yHa5yHRwthwq"; protected-headers="v1" From: Eric McCorkle <eric@metricspace.net> To: Warner Losh <imp@bsdimp.com>, Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Tommi Pernila <tommi.pernila@iki.fi>, "[ScaleEngine] Allan Jude" <allan.jude@scaleengine.com>, freebsd-current <freebsd-current@freebsd.org>, Warner Losh <imp@freebsd.org> Message-ID: <c0c57711-055a-5d0d-796e-f7acce4be3b4@metricspace.net> Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? References: <CABHD1wRyrmXp5R_ViERa-MnJnVKN-U551SWt+ehm6r+3viydxg@mail.gmail.com> <CANCZdfp-bYi2fFJi5ashPLwjnwKWeoepiPt23LfPORU1EpKNGg@mail.gmail.com> <CABHD1wQU_6wHw96+LguVuqmwqY04+n7NPcy6rSgn4QdKZpF3Kg@mail.gmail.com> <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <CABHD1wS-RoxP5fsCYgH61BsPsad_OPC4FZSUCUi6EfsWyXRzQA@mail.gmail.com> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> <f17bbb44-6735-e252-ba75-bd0b4f685d9d@metricspace.net> <CABHD1wRu_C4dPvzt+xMsYYYjFNJ1+78ne4cLsuCxr=YrN+hfFA@mail.gmail.com> <CANCZdfrkW1yteAixk44DetDe=uetVtvxM9-M7K5FioxeLseHJw@mail.gmail.com> <D667242D-ACB8-42E4-85B8-308702C15360@metricspace.net> <CAPQ4fftB27Y63yvk9zqEE3q4-MShHOYdwM7aD=c+XKzrs+ZoMw@mail.gmail.com> <CANCZdfqZ1qr0Z7eiby6Kvwop_-+3_VZ0hFnCfo7Hm1NN9UbaUA@mail.gmail.com> In-Reply-To: <CANCZdfqZ1qr0Z7eiby6Kvwop_-+3_VZ0hFnCfo7Hm1NN9UbaUA@mail.gmail.com> --ztiM6EPjGKnm5abadnKD9yHa5yHRwthwq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable I think the thing to do at this point is to wait for the current work on loader.efi to land, then adapt my patches to apply against that work. On 04/11/2018 15:06, Warner Losh wrote: > Still reviewing the code. I'm worried it's too i386 specific and it > conflicts with some work I'm doing. I'll have a list of actionable > critiques this week. >=20 > Warner >=20 > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter > <oliver.pinter@hardenedbsd.org <mailto:oliver.pinter@hardenedbsd.org>> > wrote: >=20 > Hi! >=20 > Is there any update regarding the rebase or the inclusion to base > system? > On 3/28/18, Eric McCorkle <eric@metricspace.net > <mailto:eric@metricspace.net>> wrote: > > I'll do another rebase from head just to be sure > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh <imp@bsdimp.com > <mailto:imp@bsdimp.com>> wrote: > >>It's on my list for nexr, finally. I have an alternate patch for > >>loader.efi > >>from ESP, but i don't think it will affect the GELI stuff. I have= some > >>time > >>slotted for integration issues though. > >> > >>I am quite mindful of the freeze dates.... I=C2=A0 have some uefi= boot > >>loader > >>protocol changes that I need to get in. > >> > >>Warner > >> > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" <tommi.pernila@iki.fi > <mailto:tommi.pernila@iki.fi>> wrote: > >> > >>> Awesome, thanks for the update and the work that you have done!= > >>> > >>> Now we just need some more reviewers eyes on the code :) > >>> > >>> Br, > >>> > >>> Tommi > >>> > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <eric@metricspace.ne= t > <mailto:eric@metricspace.net>> > >>wrote: > >>> > >>>> FYI, I just IFC'ed everything, and the current patches are sti= ll > >>fine. > >>>> > >>>> Also, the full GELI + standalone loader has been deployed on o= ne of > >>my > >>>> laptops for some time now. > >>>> > >>>> On 02/21/2018 18:15, Eric McCorkle wrote: > >>>> > The GELI work could be merged at this point, though it won't= be > >>usable > >>>> > without an additional patch to enable loader-only operation.= =C2=A0 The > >>>> > patches are currently up for review: > >>>> > > >>>> > This is the order in which they'd need to be merged: > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12732 > <https://reviews.freebsd.org/D12732>; > >>>> > > >>>> > This one changes the efipart device.=C2=A0 Toomas Soome iden= tified > some > >>>> > problems, which I have addressed.=C2=A0 He has not re-review= ed it, > >>however. > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12692 > <https://reviews.freebsd.org/D12692>; > >>>> > > >>>> > This adds some crypto code needed for GELI.=C2=A0 It simply = adds new > >>code, > >>>> > and doesn't conflict with anything. > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12698 > <https://reviews.freebsd.org/D12698>; > >>>> > > >>>> > This adds the EFI KMS interface code, and has the EFI loader= pass > >>keys > >>>> > into the keybuf interface. > >>>> > > >>>> > > >>>> > I can't post the main GELI driver until those get merged, as= it > >>depends > >>>> > on them.=C2=A0 It can be found on the geli branch on my gith= ub freebsd > >>>> > repository, however. > >>>> > > >>>> > > >>>> > Additionally, you need this patch, which allows loader.efi t= o > >>function > >>>> > when installed directly to the ESP: > >>>> > > >>>> > https://reviews.freebsd.org/D13497 > <https://reviews.freebsd.org/D13497>; > >>>> > > >>>> > On 02/20/2018 22:56, Tommi Pernila wrote: > >>>> >> Hi Eric, > >>>> >> > >>>> >> could you provide a brief update how the work is going? > >>>> >> > >>>> >> > >>>> >> Br, > >>>> >> > >>>> >> Tommi > >>>> >> > >>>> >> > >>>> >> On Nov 16, 2017 04:29, "Eric McCorkle" <eric@metricspace.ne= t > <mailto:eric@metricspace.net> > >>>> >> <mailto:eric@metricspace.net <mailto:eric@metricspace.net>>= > > wrote: > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0Right, so basically, the remaining GELI = patches are against > >>>> loader, and > >>>> >>=C2=A0 =C2=A0 =C2=A0most of them can go in independently of = the work on removing > >>boot1. > >>>> >>=C2=A0 =C2=A0 =C2=A0There's a unanimous consensus on getting= rid of boot1 which > >>>> includes its > >>>> >>=C2=A0 =C2=A0 =C2=A0original author, so that's going to happ= en. > >>>> >> > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0For GELI, we have the following (not nec= essarily in order): > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0a) Adding the KMS interfaces, pseudo-dev= ice, and kernel > >>keybuf > >>>> >>=C2=A0 =C2=A0 =C2=A0interactions > >>>> >>=C2=A0 =C2=A0 =C2=A0b) Modifications to the efipart driver > >>>> >>=C2=A0 =C2=A0 =C2=A0c) boot crypto > >>>> >>=C2=A0 =C2=A0 =C2=A0d) GELI partition types (not strictly ne= cessary) > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0Then there's the GELI driver itself.=C2=A0= (a) and (c) are > good to > >>>> land, (b) > >>>> >>=C2=A0 =C2=A0 =C2=A0needs some more work after Toomas Soome = pointed out a > >>legitimate > >>>> >>=C2=A0 =C2=A0 =C2=A0problem, and (d) actually needs a good b= it more code (but > >>again, > >>>> it's > >>>> >>=C2=A0 =C2=A0 =C2=A0more cosmetic).=C2=A0 Additionally, the = GELI driver will need > >>further > >>>> mods to > >>>> >>=C2=A0 =C2=A0 =C2=A0efipart to be written (nothing too big).= =C2=A0 But we could go > >>ahead > >>>> with (a) > >>>> >>=C2=A0 =C2=A0 =C2=A0and (c), as they've already been proven = to work. > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0I'd wanted to have this stuff shaped up = sooner, but I'm > >>>> preoccupied with > >>>> >>=C2=A0 =C2=A0 =C2=A0the 7th RISC-V workshop at the end of th= e month. > >>>> >> > >>>> >>=C2=A0 =C2=A0 =C2=A0Once this stuff is all in, loader should= handle any GELI > >>volumes it > >>>> >>=C2=A0 =C2=A0 =C2=A0finds, and it should Just Work once boot= 1 is gone. > >>>> >> > >>>> >> > >>>> > _______________________________________________ > >>>> > freebsd-current@freebsd.org > <mailto:freebsd-current@freebsd.org> mailing list > >>>> > https://lists.freebsd.org/mailman/listinfo/freebsd-current > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>; > >>>> > To unsubscribe, send any mail to "freebsd-current-unsubscrib= e@ > >>>> freebsd.org <http://freebsd.org>" > >>>> > > >>>> > >>> > > > > -- > > Sent from my Android device with K-9 Mail. Please excuse my brevi= ty. > > _______________________________________________ > > freebsd-current@freebsd.org <mailto:freebsd-current@freebsd.org> > mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>; > > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org > <mailto:freebsd-current-unsubscribe@freebsd.org>" > > >=20 >=20 --ztiM6EPjGKnm5abadnKD9yHa5yHRwthwq-- --j6rsGUR5EYtrs6ssNwWRg2jQQpYzSHXaK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTp6hWnRH4nHb9/QN/kI/o6qzq6mAUCWs6iAwAKCRDkI/o6qzq6 mFpoAP98KbfVs4FCPI9ncl7DXRMHofYE4kIyLPPeediPPdKpdwD+K6jx2AfyhLlI hGNrVvoSXC3U2YsTk5E41g5cnP4T/Ac= =STKF -----END PGP SIGNATURE----- --j6rsGUR5EYtrs6ssNwWRg2jQQpYzSHXaK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c0c57711-055a-5d0d-796e-f7acce4be3b4>