Date: Mon, 11 May 2020 18:10:27 +0000 From: Brooks Davis <brooks@freebsd.org> To: Kyle Evans <kevans@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360833 - head Message-ID: <20200511181027.GA60902@spindle.one-eyed-alien.net> In-Reply-To: <202005090201.04921Tpf028388@repo.freebsd.org> References: <202005090201.04921Tpf028388@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 09, 2020 at 02:01:29AM +0000, Kyle Evans wrote: > Author: kevans > Date: Sat May 9 02:01:29 2020 > New Revision: 360833 > URL: https://svnweb.freebsd.org/changeset/base/360833 >=20 > Log: > installworld: attempt a certctl rehash at the tail end > =20 > This can be run as root or normal user with no problem; if they hadn't > twisted the WITHOUT_CAROOT knob, we'll attempt to use the host certctl = to > rehash the DESTDIR. This would allow one to build systems WITHOUT_OPENS= SL + > WITH_CAROOT with a populated /etc/ssl that they can then use with an > appropriate *ssl from somewhere else. > =20 > Cross-builds are fine because this will always use the host certctl, or= just > nag if it's missing and it wasn't a WITHOUT_CAROOT build. > =20 > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D24641 >=20 > Modified: > head/Makefile.inc1 >=20 > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.inc1 Sat May 9 01:48:08 2020 (r360832) > +++ head/Makefile.inc1 Sat May 9 02:01:29 2020 (r360833) > @@ -1403,6 +1403,16 @@ distributeworld installworld stageworld: _installc= heck > ${DESTDIR}/${DISTDIR}/${dist}.debug.meta > .endfor > .endif > +.elif make(installworld) && ${MK_CAROOT} !=3D "no" > + # We could make certctl a bootstrap tool, but it requires OpenSSL and > + # friends, which we likely don't want. We'll rehash on a best-effort > + # basis, otherwise we'll just mention that we're not doing it to raise > + # awareness. > + @if which certctl>/dev/null; then \ > + certctl rehash \ Does this update METALOG with the added links? It seems a little weird to rely on DESTDIR from the environment. In general I'm not enthusiastic about additions to installworld that do anything other than copying files, creating links, etc in simple ways. -- Brooks --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeuZURAAoJEKzQXbSebgfAVx8IAJpjGA7VQT+08/rV2+4QkpO+ Dc1JDgQKqiEVwqeqPocmY22a+9fxh2hKyOQsV3cXK7jLpoapdEaVE8talZZFec/C Bs/G8hEb7EbXOwwtPOpiwtVGAqUkqTIjaw5VgnddW0ifQn5v5/oIgDoBYAtD9ahw AiEUY5Rpc4M3Hbn/8ZctOHfZ08OXgpMZy6c8FaUqame/I21D5eIAcJX7ICurFYvq 0If/QfXWKMyGNy1YsPoxxmIAs8ITYJ9fiRf33cfe8kggYQISfjL7chLtSp+2zCE4 cjey/a+8Qrob0K/BFXw6Bbj9ijEt8+rAPsbmqAM7zug/xYukPh+vMNT/QCsfGcw= =C34C -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200511181027.GA60902>