Date: Tue, 17 Apr 2012 11:09:33 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: kwhite@site.uottawa.ca, Marcel Moolenaar <marcel@freebsd.org> Subject: Re: r234118 uart kernel module failure: "uart_cpu_eqres undefined" Message-ID: <201204171109.33874.jhb@freebsd.org> In-Reply-To: <31940.74.51.53.177.1334364265.squirrel@courriel.site.uottawa.ca> References: <31940.74.51.53.177.1334364265.squirrel@courriel.site.uottawa.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 13, 2012 8:44:25 pm kwhite@site.uottawa.ca wrote:
> The change from sys/dev/uart/uart_cpu_{i386,amd64}.c to uart_cpu_x86.c
> probably also needs a corresponding change in the module Makefile.
>
> # kldload uart
> link_elf: symbol uart_cpu_eqres undefined
>
> Here's one suggestion that works for me:
>
> Index: /sys/modules/uart/Makefile
> ===================================================================
> --- /sys/modules/uart/Makefile (revision 234249)
> +++ /sys/modules/uart/Makefile (working copy)
> @@ -16,6 +16,8 @@
> uart_if.c uart_if.h uart_subr.c uart_tty.c
> .if exists(${.CURDIR}/../../dev/uart/uart_cpu_${MACHINE}.c)
> SRCS+= uart_cpu_${MACHINE}.c
> +.elif ${MACHINE} == "i386" || ${MACHINE} == "amd64"
> +SRCS+= uart_cpu_x86.c
> .endif
> SRCS+= bus_if.h card_if.h device_if.h isa_if.h ${ofw_bus_if} pci_if.h \
> power_if.h pccarddevs.h serdev_if.h
> ------------------------------------------------------------------------
cc'ing Marcel (who made the uart(4) change). I think this is correct, yes.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204171109.33874.jhb>