Date: Sat, 13 Mar 2004 19:11:31 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/py-gtk2 Makefile Message-ID: <1079223091.13553.42.camel@shumai.marcuscom.com> In-Reply-To: <20040314000513.GB65109@xor.obsecurity.org> References: <200403131801.i2DI1Xqn098604@repoman.freebsd.org> <20040314000513.GB65109@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-NY6Z+QENNkvMVb+HwH0+
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sat, 2004-03-13 at 19:05, Kris Kennaway wrote:
> On Sat, Mar 13, 2004 at 10:01:33AM -0800, Joe Marcus Clarke wrote:
> > marcus 2004/03/13 10:01:33 PST
> >=20
> > FreeBSD ports repository
> >=20
> > Modified files:
> > x11-toolkits/py-gtk2 Makefile=20
> > Log:
> > Correct a typo that prevented thread support from being enabled.
> > =20
> > Submitted by: Davide D'Amico <dave@civetta.gufi.org>
>=20
> Why is this necessary?
>=20
> > | -LIBC_R!=3D /sbin/ldconfig -r | grep "c_r|pthread" || true
> > | +LIBC_R!=3D /sbin/ldconfig -r | grep "c_r\|pthread" || true
> > | .if (${LIBC_R} !=3D "") && !defined(WITHOUT_THREADS)
> > | CONFIGURE_ARGS+=3D --enable-thread
> > | CFLAGS+=3D ${PTHREAD_CFLAGS}
>=20
> By default, every FreeBSD platform supports threads in one form or
> another (but via the same interface, PTHREAD_{CFLAGS,LIBS}) -- your
> test omits testing for libthr, by the way. The only way someone will
> have arrived at a system without threads is if they have disabled it
> with make.conf variables, so can't you just test for those if you want
> to support those systems?
I had this conversation with the original maintainer of this port a long
time ago, and there was a reason he did this. I'll try to hunt down why
this happened, and look for a better way to solve the problem it was
meant to solve.
Joe
>=20
> Kris
--=20
Joe Marcus Clarke
FreeBSD GNOME Team :: gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
--=-NY6Z+QENNkvMVb+HwH0+
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBAU6Mzb2iPiv4Uz4cRAnvSAJwPfm0mu7GHcPj1rGfCENi3Jt10MwCeMUca
YrCJsq8p2Z8Wx78kOIL/xnY=
=BHIb
-----END PGP SIGNATURE-----
--=-NY6Z+QENNkvMVb+HwH0+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1079223091.13553.42.camel>