Date: Fri, 2 Nov 2018 20:59:17 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Andriy Gapon <avg@FreeBSD.org>, Konstantin Belousov <kostikbel@gmail.com> Cc: FreeBSD Filesystems <freebsd-fs@freebsd.org>, Josh Paetzel <josh@tcbug.org> Subject: Re: How to fill in the fsid for file systems? Message-ID: <YTOPR0101MB116206605E712CACD587447ADDCF0@YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <eb03751b-46a7-5050-cc77-9da7c71128d2@FreeBSD.org> References: <YTOPR0101MB11620BAF0E206EE36E927A5ADDF30@YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM> <20181030012240.GM5335@kib.kiev.ua> <YTOPR0101MB11621427AF47133A93311E16DDCD0@YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM> <e7813a64-59c2-67a1-3471-b32a6ca42ef8@FreeBSD.org> <YTOPR0101MB116207BA89FB66EE9B1AAF01DDCD0@YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM>, <eb03751b-46a7-5050-cc77-9da7c71128d2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andriy Gapon wrote: >On 31/10/2018 17:50, Rick Macklem wrote: >> Andriy Gapon wrote: >>> One is practical. How do we provide fsid to ZFS filesystems? >>> I mean I would hate to resort to mounting ZFS via fstab just to provide= fsid >>> whereas today ZFS filesystems are mounted auto-magically. >>> We could add a FreeBSD specific fsid ZFS property, but that's also some= extra code. >> Good point. I'm not a ZFS guy, so I wouldn't have thought of this. > >A counter-point to my own point. If we implement the fsid override in the >common code, like vfs_do[n]mount, then we would not need to worry about an= y >filesystem specifics. Yes, and it would make the code easily MFC'able, since it avoids any change= s to struct export_args and mountd.c. There probably is still an argument for rev'ing struct export_args (making ex_flags 64bits so that the high order bits of mnt_flag don't get truncated= ) and allowing the anonymous user to have more than 16 gids, but there would be no rush nor a need to MFC this, I think? I'll code up a generic "fsid=3DN" option and see what others think of the p= atch, rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTOPR0101MB116206605E712CACD587447ADDCF0>