Date: Thu, 4 Dec 2008 08:13:13 +0000 (UTC) From: "G. Paul Ziemba" <pz-freebsd-ports@ziemba.us> To: freebsd-ports@freebsd.org Subject: Re: Proposal: mechanism for local patches Message-ID: <gh83eo$303t$1@hairball.ziemba.us> References: <20081203131234.GD70240@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
amdmi3@amdmi3.ru (Dmitry Marakasov) writes: >> 1. Good that it's at the end of the do-patch target - that way local >> patches can happen after the "official" patches >Not sure if it's good actually. >On the one hand, you usually have patches against vanilla sources, and >just want to drop them to some dir and have them applied. >Also, there's USE_DOS2UNIX that comes before any actual patching, so for >ports that use USE_DOS2UNIX you'll have to adapt patches by hand. >On the other hand, this may cause conflicts with patches from ports, If the local patches were applied before the official ports patches, the official patches could fail, or they could undo some of the modifications made by local patches. I think it would be an incorrect result. >From the point of view of the local patches, there is potential for variation in the upstream files regardless of whether they are modified by official ports patches, so doing local patching first doesn't let you avoid tweaking local patches from time to time. >Updated version here: >http://people.freebsd.org/~amdmi3/local-patchdir.patch It looks good to me. Thanks! -- G. Paul Ziemba FreeBSD unix: 12:11AM up 3 days, 9:41, 12 users, load averages: 0.42, 0.40, 0.37
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?gh83eo$303t$1>