Date: Sun, 29 May 2011 03:45:48 +0200 From: "deeptech71@gmail.com" <deeptech71@gmail.com> To: freebsd-current@freebsd.org Subject: Re: pcib allocation failure Message-ID: <BANLkTi=TJ-N1Edaz=woaMoMVbOET3RyDvw@mail.gmail.com> In-Reply-To: <201105260940.37035.jhb@freebsd.org> References: <BANLkTikTHFTHff5iuPDMxR6zhezEcTaZSA@mail.gmail.com> <BANLkTin4=FTeJeBhv9Tp5DkWo8TbTf-cvA@mail.gmail.com> <BANLkTimBBR3yJsRsx7qv4cpnkpBAZuJuFA@mail.gmail.com> <201105260940.37035.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 26, 2011 at 3:40 PM, John Baldwin <jhb@freebsd.org> wrote:
> Ohh, you have two devices behind this bridge that have prefetch ranges.
>
> As a hack, can you try this:
>
> Index: pci_pci.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- pci_pci.c =A0 (revision 222285)
> +++ pci_pci.c =A0 (working copy)
> @@ -162,8 +162,13 @@ pcib_write_windows(struct pcib_softc *sc, int mask
> =A0{
> =A0 =A0 =A0 =A0device_t dev;
> =A0 =A0 =A0 =A0uint32_t val;
> + =A0 =A0 =A0 uint16_t cmd;
>
> =A0 =A0 =A0 =A0dev =3D sc->dev;
> + =A0 =A0 =A0 cmd =3D pci_read_config(dev, PCIR_COMMAND, 2);
> + =A0 =A0 =A0 if (cmd & (PCIM_CMD_PORTEN | PCIM_CMD_MEMEN))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 pci_write_config(dev, PCIR_COMMAND,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cmd & ~(PCIM_CMD_PORTEN | PCIM_CMD_=
MEMEN), 2);
> =A0 =A0 =A0 =A0if (sc->io.valid && mask & WIN_IO) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0val =3D pci_read_config(dev, PCIR_IOBASEL_=
1, 1);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if ((val & PCIM_BRIO_MASK) =3D=3D PCIM_BRI=
O_32) {
> @@ -192,6 +197,8 @@ pcib_write_windows(struct pcib_softc *sc, int mask
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pci_write_config(dev, PCIR_PMBASEL_1, sc->=
pmem.base >> 16, 2);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pci_write_config(dev, PCIR_PMLIMITL_1, sc-=
>pmem.limit >> 16, 2);
> =A0 =A0 =A0 =A0}
> + =A0 =A0 =A0 if (cmd & (PCIM_CMD_PORTEN | PCIM_CMD_MEMEN))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 pci_write_config(dev, PCIR_COMMAND, cmd, 2)=
;
> =A0}
>
> =A0static void
> @@ -337,6 +344,9 @@ pcib_probe_windows(struct pcib_softc *sc)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pci_read_config(de=
v, PCIR_PMLIMITL_1, 2));
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0max =3D 0xffffffff;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* XXX: Testing hack */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (device_get_unit(sc->sc_dev) =3D=3D 1)
i'm assuming that "sc->sc_dev" should be "dev" (this fixes a compilation er=
ror).
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 sc->pmem.limit =3D 0xefffff=
ff;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pcib_alloc_window(sc, &sc->pmem, SYS_RES_M=
EMORY,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0RF_PREFETCHABLE, max);
> =A0 =A0 =A0 =A0}
that seems to work!
btw, is my machine a test-pig for an upcoming change to the PCI bus driver?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=TJ-N1Edaz=woaMoMVbOET3RyDvw>