Date: Tue, 14 Jul 2009 10:04:39 -0500 From: Robert Noland <rnoland@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r195679 - in stable/7/sys: . contrib/pf dev/pci Message-ID: <1247583879.1745.24.camel@balrog.2hip.net> In-Reply-To: <200907141456.n6EEu1du062934@svn.freebsd.org> References: <200907141456.n6EEu1du062934@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-F/l7SUirLr6zh0DZZy/M Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2009-07-14 at 14:56 +0000, John Baldwin wrote: > Author: jhb > Date: Tue Jul 14 14:56:01 2009 > New Revision: 195679 > URL: http://svn.freebsd.org/changeset/base/195679 >=20 > Log: > MFC: Enable MSI in the MSI capability registers any time that the first > message in an MSI group is enabled, not just if the address/data pair a= re > not initialized. With this MFC, Intel drm on 965+ chipsets should suck substantially less than before. i.e. This should fix interrupts after a VT Switch issue. I'll follow on and MFC the rest of the changes from HEAD in the next day or so. robert. > Modified: > stable/7/sys/ (props changed) > stable/7/sys/contrib/pf/ (props changed) > stable/7/sys/dev/pci/pci.c >=20 > Modified: stable/7/sys/dev/pci/pci.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/7/sys/dev/pci/pci.c Tue Jul 14 14:41:48 2009 (r195678) > +++ stable/7/sys/dev/pci/pci.c Tue Jul 14 14:56:01 2009 (r195679) > @@ -2869,8 +2869,10 @@ pci_setup_intr(device_t dev, device_t ch > goto bad; > dinfo->cfg.msi.msi_addr =3D addr; > dinfo->cfg.msi.msi_data =3D data; > - pci_enable_msi(child, addr, data); > } > + if (dinfo->cfg.msi.msi_handlers =3D=3D 0) > + pci_enable_msi(child, dinfo->cfg.msi.msi_addr, > + dinfo->cfg.msi.msi_data); > dinfo->cfg.msi.msi_handlers++; > } else { > KASSERT(dinfo->cfg.msix.msix_alloc > 0, --=20 Robert Noland <rnoland@FreeBSD.org> FreeBSD --=-F/l7SUirLr6zh0DZZy/M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAkpcnocACgkQM4TrQ4qfROO++wCfSNn5PmM6Fd9B0mZTgO20MCDb 9OkAnjEStI/j84WhiKKXKlNn2k5La5Mv =GrSP -----END PGP SIGNATURE----- --=-F/l7SUirLr6zh0DZZy/M--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1247583879.1745.24.camel>