Date: Thu, 16 Jan 1997 19:19:54 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, dg@root.com Cc: bugs@freebsd.org, dyson@freebsd.org, wollman@freebsd.org Subject: Re: malloc(..., M_WAITOK) found harmful Message-ID: <199701160819.TAA28376@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Here are my diffs to combine the maps. >Index: i386/i386/machdep.c old>! mb_map = kmem_suballoc(kmem_map, &minaddr, &maxaddr, old>! round_page(mb_map_size), FALSE); new>! mb_map = kmem_suballoc(kmem_map, (vm_offset_t *)&mbutl, &maxaddr, new>! mb_map_size, FALSE); Please format code with less than 80 columns, especially when the code was already formatted that way, and even more especially when the line has to be split anyway. The style guide says to use a continuation indent of 4 (indent -ci4), but this is ugly and rarely used in non-CSRG FreeBSD code. >Index: vm/vm_kern.c old>! log(LOG_ERR, old>! "Out of mbuf clusters - increase maxusers!\n"); new>! log(LOG_ERR, "Out of mbuf clusters - increase maxusers!\n"); Similarly. -ci4 happens to match the right rule (-lp). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701160819.TAA28376>