Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Jun 2021 07:25:00 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d26ef5c7ac83 - main - pf: make sure the dtrace probe has safe access to state
Message-ID:  <202106290725.15T7P0Gt068219@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=d26ef5c7ac830812f07a02787f25fed5d6f8609e

commit d26ef5c7ac830812f07a02787f25fed5d6f8609e
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-06-28 19:32:20 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-06-29 07:24:53 +0000

    pf: make sure the dtrace probe has safe access to state
    
    Reviewed by:    kp
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sys/netpfil/pf/pf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index 69cdc75f0f41..39b032962e84 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -6297,11 +6297,12 @@ done:
 		}
 		break;
 	}
-	if (s)
-		PF_STATE_UNLOCK(s);
 
 	SDT_PROBE4(pf, ip, test, done, action, reason, r, s);
 
+	if (s)
+		PF_STATE_UNLOCK(s);
+
 	return (action);
 }
 #endif /* INET */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202106290725.15T7P0Gt068219>