Date: Mon, 27 Aug 2001 09:26:32 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, (Dima Dorfman) <dima@unixfreak.org> Subject: Re: cvs commit: src/sys/dev/md md.c Message-ID: <XFMail.010827092632.jhb@FreeBSD.org> In-Reply-To: <200108271446.f7REkBL49390@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27-Aug-01 Maxim Sobolev wrote: >> >> >> On 27-Aug-01 Dima Dorfman wrote: >> > Maxim Sobolev <sobomax@FreeBSD.org> wrote: >> >> sobomax 2001/08/27 06:25:48 PDT >> >> >> >> Modified files: >> >> sys/dev/md md.c >> >> Log: >> >> - On module unload try to detach all configured disks and let unload >> >> proceed >> >> if all disks were detached sucessfully; >> > >> > I'm not sure this is wise. More likely than not, trying to unload md >> > while there are still disks attached is a mistake on the user's part, >> > especially considering that most people aren't going to be loading and >> > unloading it on a regular basis. I understand why this may be useful >> > for a developer working on md, but it seems counter-intuitive from a >> > regular user's perspective. >> >> Yeah, I'd rather get an error (You're still using this stupid! *bonk*) like >> EBUSY or some such rather than have it do magical things for me behind my >> back. > > Folks, have you tried to look into patches in question before commenting > on them (no pun intended)? As I said the driver will try to detach *idle* > disks only (i.e. configured but not opened), so they aren't really "in > use". Erm, you said "all configured disks". This does not clearly say "all configured but not opened disks". An opened disk is obviously configured, so it easily fits in the set of all configured disks. However, with the extra explanation, it now seems ok. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010827092632.jhb>