Date: Mon, 5 Feb 2018 13:32:04 -0800 From: Jason Harmening <jason.harmening@gmail.com> To: "O. Hartmann" <ohartmann@walstatt.org> Cc: David Wolfskill <david@catwhisker.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328489 - head/sys/conf Message-ID: <CAM=8qanb9LDq4QhaJSAeu99gY4f975p0ZhfMWYi=uL1eY7CTkA@mail.gmail.com> In-Reply-To: <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de> References: <201801272013.w0RKDaMU098200@repo.freebsd.org> <20180127214755.3c59661e@thor.intern.walstatt.dynvpn.de> <98501f75-1a1b-9221-c52d-24415230a886@gmail.com> <20180129130022.GT1125@albert.catwhisker.org> <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> <e6a89b40-8ce3-d688-d9ec-c918718a0509@gmail.com> <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 5, 2018 at 1:25 PM, O. Hartmann <ohartmann@walstatt.org> wrote:
> Am Sun, 4 Feb 2018 10:22:31 -0800
> Jason Harmening <jason.harmening@gmail.com> schrieb:
>
> > On 02/04/18 04:33, O. Hartmann wrote:
> > > Am Mon, 29 Jan 2018 05:00:22 -0800
> > > David Wolfskill <david@catwhisker.org> schrieb:
> > >
> > >> On Mon, Jan 29, 2018 at 02:10:04AM -0800, Jason Harmening wrote:
> > >>>>
> > >>>> This happens now if PORTS_MODULE=3Dx11/nvidia-driver is defined in
> /etc/src.conf:
> > >>>>
> > >>>> [...]
> > >>>> --- kernel-install ---
> > >>>> mkdir -p /boot/kernel
> > >>>> install -p -m 555 -o root -g wheel kernel /boot/kernel/
> > >>>> --- ports-install ---
> > >>>> Variable OBJTOP is recursive.
> > >>>>
> > >>>> make[8]: stopped
> > >>> ...
> > >>>
> > >>> David sent me logs of the failing case; thanks David!
> > >>
> > >> Happy to help! :-)
> > >>
> > >>> The failure happens when buildkernel and installkernel are run
> > >>> separately instead of all-up, e.g. 'make kernel'. The installkerne=
l
> > >>> step is leaving MK_AUTO_OBJ=3Dno in the env passed to the port buil=
d.
> It
> > >>> looks like at least one of the install stages of nvidia-driver need=
s
> to
> > >>> generate temporary output, which leads to confusion when the port
> isn't
> > >>> built as though it's an in-tree component.
> > >>>
> > >>> Can you guys try out the attached patch?
> > >>
> > >> I tried it both on my build machine (which does not use kernel modul=
es
> > >> from ports, and thus did not exhibit the problem -- but I thought th=
at
> > >> verifying that the patch did not break that case worth checking) and
> on
> > >> my laptop (which did exhibit the problem).
> > >>
> > >> It worked in both cases with no issues for me.
> > >>
> > >> Thanks! :-)
> > >>
> > >> Peace,
> > >> david
> > >
> > > The problem still persists!
> > >
> > > I'm on CURRENT, FreeBSD 12.0-CURRENT #32: Sun Feb 4 09:41:39 CET 201=
8
> amd64, the
> > > source tree is at revision 328839.
> > >
> > >
> > > I use WITH_META_MODE=3DYES in /etc/src.conf. My /etc/make.conf consis=
ts
> of a .include
> > > statement which reels in /usr/local/etc/ports.conf in which I define
> everything
> > > outside the source tree for ports (in case of the nvidia driver, its
> DISTVERSION).
> > > This worked before and should work again. Today I checked out a
> completely
> > > fresh /usr/src and gleanced the /usr/obj folder and rebuilt the syste=
m
> - and get the
> > > error again:
> > >
> > > [...]
> > > =3D=3D=3D> Ports module x11/nvidia-driver (install)
> > > cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u
> CPP -u
> > > MAKESYSPATH MAKEFLAGS=3D"-j 4 -J 15,16 .MAKE.LEVEL.ENV=3DMAKELEVEL
> KERNEL=3Dkernel
> > > MK_AUTO_OBJ=3Dno
> > ^^^=
^^
> > Looks like you haven't applied the patch? MK_AUTO_OBJ being left set i=
n
> > MAKEFLAGS by installkernel was part of the problem.
> >
> > That said, the fix I have up for review is slightly different:
> > https://reviews.freebsd.org/D14143
> >
> > > TARGET=3Damd64 TARGET_ARCH=3Damd64" SYSDIR=3D/usr/src/sys
> > > PATH=3D/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/
> usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/
> usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/
> amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/
> usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin
> > > SRC_BASE=3D/usr/src OSVERSION=3D1200056
> > > WRKDIRPREFIX=3D/usr/obj/usr/src/amd64.amd64/sys/THOR make -B deinstal=
l
> reinstall =3D=3D=3D>
> > > Deinstalling for nvidia-driver =3D=3D=3D> Deinstalling
> nvidia-driver-387.34 Updating
> > > database digests format: . done Checking integrity... done (0
> conflicting)
> > > Deinstallation has been requested for the following 1 packages (of 0
> packages in the
> > > universe):
> > >
> > > Installed packages to be REMOVED:
> > > nvidia-driver-387.34
> > >
> > > Number of packages to be removed: 1
> > >
> > > The operation will free 99 MiB.
> > > [1/1] Deinstalling nvidia-driver-387.34...
> > > [1/1] Deleting files for nvidia-driver-387.34: .......... done
> > > =3D=3D=3D> Staging for nvidia-driver-387.34
> > > =3D=3D=3D> nvidia-driver-387.34 depends on file: /usr/local/lib/lib=
GL.so -
> found
> > > =3D=3D=3D> nvidia-driver-387.34 depends on file:
> /usr/local/libdata/pkgconfig/x11.pc -
> > > found =3D=3D=3D> nvidia-driver-387.34 depends on
> > > file: /usr/local/libdata/pkgconfig/xorg-server.pc
> > > - found =3D=3D=3D> nvidia-driver-387.34 depends on
> > > file: /usr/local/libdata/pkgconfig/xext.pc
> > > - found =3D=3D=3D> Generating temporary packing list
> > > =3D=3D=3D> src (install)
> > > =3D=3D=3D> src/nvidia (install)
> > > Variable OBJTOP is recursive.
> > >
> > > make[8]: stopped
> > > in /usr/obj/usr/src/amd64.amd64/sys/DUMMBOX/usr/ports/x11/
> nvidia-driver/work/NVIDIA-FreeBSD-x86_64-387.34/src/nvidia
> > > *** Error code 2
> > >
> > >
> > >
> > > Oliver
> > >
>
> make -jX installkernel with the above mentioned setting of PORTS_MODULE=
=3D
> set
> in /usr/src.conf doesn't wor even on recent CURRENT r328901.
>
> make kernel doesn't fail.
>
Yes, that is because there is a patch, included in an earlier email, which
fixes this failure and hasn't yet made it into the tree.
Based on the fact that I can see MK_AUTO_OBJ=3Dno in your installkernel
output, it looks like you haven't applied the patch to your src tree.
Can you try downloading the raw diff from
https://reviews.freebsd.org/D14143 and
applying that to src?
>
>
> oh
>
> --
> O. Hartmann
>
> Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr
> Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Ab=
s. 4 BDSG).
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAM=8qanb9LDq4QhaJSAeu99gY4f975p0ZhfMWYi=uL1eY7CTkA>