Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Mar 2017 18:23:46 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r316040 - stable/10/lib/libkvm
Message-ID:  <201703271823.v2RINkun018257@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Mon Mar 27 18:23:45 2017
New Revision: 316040
URL: https://svnweb.freebsd.org/changeset/base/316040

Log:
  MFC r315595,r315603:
  
  r315595:
  
  Remove a commented out line before kvm_getprocs(3)
  
  The commented out return value for kvm_getprocs(3) was misleading -- the
  uncommented line is correct.
  
  No content change
  
  r315603:
  
  kvm_close(3): return `error` instead of blindly returning `0`
  
  `error` is the accumulated error from previous close(2) calls.
  
  This bug has been present since the libcall's import from 4.4BSD
  Lite (r1573).
  
  Noticed by:	vangyzen (D10022)
  Relnotes:	yes

Modified:
  stable/10/lib/libkvm/kvm.c
  stable/10/lib/libkvm/kvm_getprocs.3
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libkvm/kvm.c
==============================================================================
--- stable/10/lib/libkvm/kvm.c	Mon Mar 27 18:22:33 2017	(r316039)
+++ stable/10/lib/libkvm/kvm.c	Mon Mar 27 18:23:45 2017	(r316040)
@@ -280,7 +280,7 @@ kvm_close(kvm_t *kd)
 		free((void *)kd->argv);
 	free((void *)kd);
 
-	return (0);
+	return (error);
 }
 
 /*

Modified: stable/10/lib/libkvm/kvm_getprocs.3
==============================================================================
--- stable/10/lib/libkvm/kvm_getprocs.3	Mon Mar 27 18:22:33 2017	(r316039)
+++ stable/10/lib/libkvm/kvm_getprocs.3	Mon Mar 27 18:23:45 2017	(r316040)
@@ -47,7 +47,6 @@
 .In sys/param.h
 .In sys/sysctl.h
 .In sys/user.h
-.\" .Fa kvm_t *kd
 .Ft struct kinfo_proc *
 .Fn kvm_getprocs "kvm_t *kd" "int op" "int arg" "int *cnt"
 .Ft char **



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703271823.v2RINkun018257>