Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jun 2022 09:29:52 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        gecko@FreeBSD.org
Subject:   Fix the restart button
Message-ID:  <20220616072952.o7jeeiswo6x5ftok@aniel.nours.eu>

next in thread | raw e-mail | index | archive | help
Hello,

I have stolen this patch from OpenBSD, which was done to please pledge, but in
the end fixes the restart button.

https://bapt.nours.eu/patch-xpcom_build_BinaryPath.h

If my investigation is right, firefox when one click on the restart button (in
case of upgrade) will call for the sysctl KERN_PROC_PATHNAME, which will return
en empty value, because the binary has been unlinked and replace by the new one.
(the behaviour is different on linux here) but forcing the path at buildtime
make it work reliably and at least here, it makes the restart button working
reliably

note that it needs a post-patch target to replace %%PREFIX%% in
xpcom/build/BinaryPath.h file.

Best regards,
Bapt



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220616072952.o7jeeiswo6x5ftok>