Date: Sat, 27 Jan 2018 14:51:17 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Emmanuel Vadot <manu@bidouilliste.com>, Adrian Chadd <adrian.chadd@gmail.com>, Poul-Henning Kamp <phk@phk.freebsd.dk>, John Baldwin <jhb@freebsd.org>, Ravi Pokala <rpokala@mac.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <CANCZdfqLtgPgUypA9A7JdWTG8G2kgys6n7JHEtd2amiknhbJZQ@mail.gmail.com> In-Reply-To: <201801272132.w0RLWMqi011256@pdx.rh.CN85.dnsmgr.net> References: <20180127214840.dc033d582696ff7b51f6d7e6@bidouilliste.com> <201801272132.w0RLWMqi011256@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 27, 2018 2:32 PM, "Rodney W. Grimes" <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > On Sat, 27 Jan 2018 12:13:57 -0800 > Adrian Chadd <adrian.chadd@gmail.com> wrote: > > > Hi, > > > > Find the middle ground. Don't dissuade the developer too much. > > This is what happened two years ago when I started hacking on the > allwinner SoCs : > > - I asked what should be done for bringing a new board > - andrew@ told me that we first need to switch to upstream dts and > update drivers. > - Guess what, I did that. Great, thats good co-operatation and communications, sometimes though it is not so smooth. The better we become at dealing with the not so smooth the faster forward progress can be made. The path we are on is the fastest. > > Here's an example: > > > > Make the driver follow DTS, allow a tunable/kenv check for it to > > override whether it needs to be in the DTS or not (the "keep phk happy > > for now" compromise) and have it default to obeying the device tree. > > > > That way phk is kept happy and the defaults are the same as normal-ish > > ARM /and/ you have a springboard to experiment with extending FDT > > overlays at runtime for people who wish to do so. > > I don't care about keeping phk@ (or any other developer) happy, we > have a standard, let's stick to it. *sigh* Let me ask you if you do not care about keeping any other developers happy, why should any of them be concerned about keeping you happy? We need to always try to find middle ground and co-operate in positive ways. On the "we have a standard" front, well when standards get in the way of forward progress they are often side stepped. Maybe this standard is not such a good standard and warts are going to form around it. I have seen some discusssion at least on ways to improve the current situation, hopefully someone takes them and runs with them. Others have pointed out they do not like the current model in that it gets in the way of developement progress. I can see this point. I can see phk's points, and I can see your points. IMHO if we shove the standard down our own throats we are in effect cutting our hands off in the process, not somethig we really want to do is it? It beats the chaos we had before where nothing was leveraged and everything was a custom hack. > > (I personally hate having to edit the dts/recompile/reboot for every > > test hardware change; it makes breadboarding things up kinda > > hilariously annoying.) > > Use overlays then. And if you don't want to reboot provide patch for > loading overlays at runtime. Are those the only solutions? Yes. Unless you show up with a boatload of work. There is a decade of history here that I'm loathe to just ignore. I have some WiP that will make things better, but it is complicated. You can't just enable the device. You have to change the pinctl stuff too. People saying just do this hack or that hack which ignores this will be ignored as their solution is incomplete (and basically useless). My advice is to see where we are once I find a few minutes to finish my WiP before pronouncing the right way forward. Or you can comment on the design I sent a week ago. Warner > > -adrian > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org> -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqLtgPgUypA9A7JdWTG8G2kgys6n7JHEtd2amiknhbJZQ>