Date: Fri, 20 Mar 2015 04:54:19 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 198725] bsdgrep broken -f option since r268799 Message-ID: <bug-198725-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198725 Bug ID: 198725 Summary: bsdgrep broken -f option since r268799 Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: sg2342@googlemail.com Created attachment 154549 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154549&action=edit fix for broken -f option in bsdgrep In r268799 the read_patterns function of grep.c was changed to use getline(3) instead of fgetln(3). The necessary change to the add_pattern call parameters is missing which breaks the -f option. The NetBSD grep.c (CVS Rev. 1.6) change that was supposed to be imported in this commit does not contain the mistake. The test that is supposed to ensure that -f works is unfortunately only run with GNU grep (unless WITH_BSD_GREP=true is set). -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198725-8>