Date: Thu, 14 Feb 2008 17:34:26 -0600 From: Matthew Grooms <mgrooms@shrew.net> To: freebsd-net@freebsd.org Subject: KAME IPsec spd_delete2 bug ... Message-ID: <47B4D002.5090101@shrew.net>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------050209060208070009030704
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
All,
There is a bug in /usr/src/sys/netipsec/key.c in FreeBSD KAME IPsec
sources. If an spd_delete2 message is submitted for an invalid policy
id, the kernel crashes. Can someone please commit this trivial patch?
I'm afraid its against 6.2 sources but its also only one line.
Thanks,
-Matthew
--------------050209060208070009030704
Content-Type: text/plain;
name="spddelete.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="spddelete.diff"
--- key.c Fri Feb 15 02:18:16 2008
+++ key.c.fixed Fri Feb 15 02:18:35 2008
@@ -2125,7 +2125,7 @@
/* Is there SP in SPD ? */
if ((sp = key_getspbyid(id)) == NULL) {
ipseclog((LOG_DEBUG, "%s: no SP found id:%u.\n", __func__, id));
- key_senderror(so, m, EINVAL);
+ return key_senderror(so, m, EINVAL);
}
sp->state = IPSEC_SPSTATE_DEAD;
--------------050209060208070009030704--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47B4D002.5090101>