Date: Tue, 14 Jan 2014 17:08:11 +0100 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com> To: Julien Grall <julien.grall@linaro.org> Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org Subject: Re: [PATCH v10 14/20] xen: introduce xenpv bus and a dummy pvcpu device Message-ID: <52D560EB.8040108@citrix.com> In-Reply-To: <52D55AB4.4010504@linaro.org> References: <1389711582-66908-1-git-send-email-roger.pau@citrix.com> <1389711582-66908-15-git-send-email-roger.pau@citrix.com> <52D55AB4.4010504@linaro.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/01/14 16:41, Julien Grall wrote:
> On 01/14/2014 02:59 PM, Roger Pau Monne wrote:
>> +static int
>> +xenpv_attach(device_t dev)
>> +{
>> + device_t child;
>> +
>> + if (xen_hvm_domain()) {
>> + device_t xenpci;
>> + devclass_t dc;
>> +
>> + /* Make sure xenpci has been attached */
>> + dc = devclass_find("xenpci");
>> + if (dc == NULL)
>> + panic("unable to find xenpci devclass");
>> +
>> + xenpci = devclass_get_device(dc, 0);
>> + if (xenpci == NULL)
>> + panic("unable to find xenpci device");
>> +
>> + if (!device_is_attached(xenpci))
>> + panic("trying to attach xenpv before xenpci");
>> + }
>
> Can you use the identify method to add the xenpci device?
I don't think so, xenpci is a pci device, it is detected and plugged by
the pci bus code.
> As I said earlier, I will reuse this code for ARM guest and this device
> is not used on this architecture.
You could move this chunk of code (the check for xenpci) to a static
inline function and make it a noop for ARM.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52D560EB.8040108>