Date: Sun, 3 Aug 2014 22:45:57 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@freebsd.org> Subject: Re: svn commit: r267937 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/json cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/... Message-ID: <87DB8CBC-4F3B-4F81-A377-0B7DB67F9A84@bsdimp.com> In-Reply-To: <9989584F-4933-4E20-B274-57CF7256272A@gmail.com> References: <201406262145.s5QLjnJH034761@svn.freebsd.org> <2037442.AGE2eZkv8p@pippin.baldwin.cx> <9989584F-4933-4E20-B274-57CF7256272A@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Aug 3, 2014, at 9:47 AM, Warner Losh <imp@bsdimp.com> wrote: > > On Jul 28, 2014, at 9:23 PM, John Baldwin <jhb@FreeBSD.org> wrote: > >> On Thursday 26 June 2014 21:45:49 Rui Paulo wrote: >>> Author: rpaulo >>> Date: Thu Jun 26 21:45:49 2014 >>> New Revision: 267937 >>> URL: http://svnweb.freebsd.org/changeset/base/267937 >>> >>> Log: >>> MFV illumos >>> >>> 4477 DTrace should speak JSON >>> >>> MFC after: 2 weeks >> >> This makes kernel builds depend on userland sources. This breaks a lot of my >> work trees where I only checkout 'sys', and breaks a generally long-standing >> feature that the kernel was self-contained (recent bmake breakage to require >> the '-m /usr/src/share/mk' hack aside). Perhaps you could copy strtolctype.h >> to sys/cddl/contrib/opensolaris/common/util? We already duplicate >> sys/cddl/contrib/opensolaris/common/avl/avl.c in a like manner, presumably for >> the same reason. > > Just FYI: my intention is to remove that hack requirement, at least for host != kernel > version cases.. I’ve had some issues with the “fix” that wound up with a different > set of hacks once the initial MAKESYSPATH is fixed. Ah, the modules issue… I didn’t understand the breakage until I tried it myself... https://phabric.freebsd.org/D529 will fix it, if anybody wants to comment on it. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJT3xAFAAoJEGwc0Sh9sBEA2AoQAINE+MjA/+l+Z5v1XYswqhK3 QV4vrBuTe922ONNQLRGN4hI00hTc2cF2SjeAZLpXvNGHv3gELYsFzvR9sk3aoG2U wzk/Ezd0twK/Q+xJHpDiEosaWUZacYxVSrKBrm3Esb5axmzb1l3uXRCgHnYB1pLX stqywXPb5anh1RjNb8T9hvrugMtAbgIXjxDipM6rwslyXzmlHm8zwvH8KErgb+7O 97vgOf1cRg2wB1G8boXANgO2q5Zd0ygsm1AYsXwECgH2/iCk1nAEALF7GzbJv1Pt 7HuKKIkGTwwDM6D9/tcun5DKbcesJZlLFp+4/Oau4Wf+Bgsh3fsG5TsbmZpcqgp1 XGuouOuJ2Izjvt1D8WUoQnnkO/tKdC8FM05IdvdT4A+Sdr7xLIurN2x9fB2tVaSK s8IlKzsqWFjgSuKLtKgCg5Rgp3+cxbf5ZGFy7HPdXnrbDGBFbQqCYPyXvHDB0BSK 9hTUOq0OrHL7PgkCvIopPT4aVrSshdH8JMJxGNOPi1nclyW80hH3xqbEtBwZaDUn GR4+z7u98l8crj2F1DFenJ50Xx2RwBxkAo7BQdp3UifBi56qQ11o0aLq6t7wqugm H10thUHRQPq/PbfzcSRfhrKuQ9RxFZ8cUFhxIlbpNLcoo+GY7PaGOU/S2S2l3uTy D6adNCb/1YY8uGrHWiSi =9yPU -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87DB8CBC-4F3B-4F81-A377-0B7DB67F9A84>