Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Sep 2008 13:11:14 -0700
From:      Marcel Moolenaar <xcllnt@mac.com>
To:        Andriy Gapon <avg@icyb.net.ua>
Cc:        freebsd-current@freebsd.org
Subject:   Re: sio => uart: one port is gone
Message-ID:  <1A6B5018-ABC9-4612-A66A-1A6D21336619@mac.com>
In-Reply-To: <48CEBF42.3060901@icyb.net.ua>
References:  <48CE59C2.9060307@icyb.net.ua> <48CE91AB.3000200@icyb.net.ua> <9D0F7169-9461-4F32-9420-702BED840A20@mac.com> <200809151522.08679.jhb@freebsd.org> <48CEBF42.3060901@icyb.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sep 15, 2008, at 1:02 PM, Andriy Gapon wrote:

> --- a/sys/conf/files
> +++ b/sys/conf/files
> @@ -1080,7 +1080,7 @@ dev/twe/twe.c			optional twe
> dev/twe/twe_freebsd.c		optional twe
> dev/tx/if_tx.c			optional tx
> dev/txp/if_txp.c		optional txp
> -dev/uart/uart_bus_acpi.c	optional	uart acpi
> +dev/uart/uart_bus_acpi.c	optional	uart
> #dev/uart/uart_bus_cbus.c	optional	uart cbus
> dev/uart/uart_bus_ebus.c	optional	uart ebus
> dev/uart/uart_bus_isa.c		optional	uart isa

This is exactly the thing we shouldn't be doing.

You now compile the acpi bus attachment on platforms
that don't even have acpi. This is not a fix, it's
a breakage...

-- 
Marcel Moolenaar
xcllnt@mac.com






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A6B5018-ABC9-4612-A66A-1A6D21336619>