Date: Fri, 5 Jan 2018 21:36:58 +0100 From: "Tobias C. Berner" <tcberner@freebsd.org> To: Yuri <yuri@rawbw.com> Cc: "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457914 - in head: . Mk/Uses astro/kstars audio/csound6 biology/iqtree cad/freecad cad/openscad deskutils/kdeplasma-addons editors/calligra games/xptools graphics/code-eli graphics/colm... Message-ID: <CAOshKteOjLKF-mmyz0%2BRPAcPEd64WD==eJZWmbm9JKO1OVRbpQ@mail.gmail.com> In-Reply-To: <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com> References: <201801021649.w02GnOap052049@repo.freebsd.org> <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Yuri,
1) It only checks against valid versions 2,3, and is happy as long as it
gets exactly one of them.
Yes, you're right I could/should probably add a check so that it only
accepts "2 3 build run".
2) I think that's the normal terminology :) - also :run_only would be a bit
of a clutch to write, even
if it were more explicit.
3) Technically yes, but I'd say it makes it a bit too over-engineered. :)
mfg Tobias
On 2 January 2018 at 19:51, Yuri <yuri@rawbw.com> wrote:
> On 01/02/18 08:49, Tobias C. Berner wrote:
>
>> Usage:
>> USES=eigen:<version>[,<type>]
>> version: 2 or 3 (required)
>> type: build (default), run
>>
>
>
> I have 3 questions:
>
>
> 1. Why doesn't eigen.mk check for invalid argument values? For example,
> USES=eigen:3,4,build,run doesn't cause an error as it should. I had the
> same question about other USES modules, but am asking here because
> eigen.mk is freshly added. It seems like checking for invalid values can
> be a good idea?
>
>
> 2. Maybe it would be beneficial to explain in the module when particular
> arguments should be used:
>
> USES=eigen:{2,3} (defaults to build) - should be used when the port uses
> Eigen headers during build, but doesn't install any headers that depend on
> Eigen
>
> USES=eigen:{2,3},run - should be used when the port doesn't use Eigen
> during build, but installs headers that depend on Eigen
>
> USES=eigen:{2,3},build,run - should be used when the port both uses Eigen
> during build, and installs headers that depend on Eigen
>
> It might not be obvious that 'run' should be used when the installed
> headers use it.
>
>
> 3. Maybe USES=eigen:{2,3},build should conflict with NO_BUILD=yes, as
> these are incompatible conditions? It seems like this could easily catch
> some mistakes.
>
>
> Thanks,
>
> Yuri
>
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOshKteOjLKF-mmyz0%2BRPAcPEd64WD==eJZWmbm9JKO1OVRbpQ>