Date: Mon, 5 Mar 2001 01:26:56 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Andrea Campi <andrea@webcom.it> Cc: arch@FreeBSD.org Subject: Re: Using CPUTYPE in COPTFLAGS Message-ID: <20010305012655.A67721@mollari.cthul.hu> In-Reply-To: <20010305101156.A367@webcom.it>; from andrea@webcom.it on Mon, Mar 05, 2001 at 10:11:56AM %2B0100 References: <20010304175829.A45353@mollari.cthul.hu> <20010304180911.A45581@mollari.cthul.hu> <20010305101156.A367@webcom.it>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Mon, Mar 05, 2001 at 10:11:56AM +0100, Andrea Campi wrote:
> > Index: share/mk/bsd.cpu.mk
> > ===================================================================
> > RCS file: /mnt/ncvs/src/share/mk/bsd.cpu.mk,v
> > retrieving revision 1.2
> > diff -u -r1.2 bsd.cpu.mk
> > --- share/mk/bsd.cpu.mk 2001/02/27 11:21:47 1.2
> > +++ share/mk/bsd.cpu.mk 2001/03/05 01:50:44
> > @@ -28,46 +28,52 @@
> > # after /etc/make.conf so it can react to the local value of CPUTYPE
> > # defined therein.
> >
> > -.if !defined(NO_CPU_CFLAGS)
> > +.if !defined(NO_CPU_CFLAGS) || !defined(NO_CPU_COPTFLAGS)
> > . if ${MACHINE_ARCH} == "i386"
> > . if ${CPUTYPE} == "k7"
> > -CFLAGS += -march=k6 # gcc doesn't support athlon yet, but it will
> > +CPUCFLAGS = -march=k6 # gcc doesn't support athlon yet, but it will
> > . elif ${CPUTYPE} == "k6-2"
> > -CFLAGS += -march=k6
> > +CPUCFLAGS = -march=k6
> > . elif ${CPUTYPE} == "k6"
>
> Are you sure this is what you really want? If I have
>
> # NO_CPU_CFLAGS=no
> NO_CPU_COPTFLAGS=yes
>
> then the `if' evaluates to true and you end up with CPUCFLAGS defined. If this
> is intended, it's at least not very intuitive...
Yes, but CPUCFLAGS is only used internally, and it will only be added
to CFLAGS or COPTFLAGS if the NO_* switches aren't defined.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE6o1vfWry0BWjoQKURAqiNAKC7xiaKGsoulMvisA6j6RKB8x2YZACdE8uR
OqOzMI76msvzRWyOoRsehM0=
=IwyI
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010305012655.A67721>