Date: Fri, 23 Mar 2012 10:12:45 +0100 From: Monthadar Al Jaberi <monthadar@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-net@freebsd.org, Bernhard Schmidt <bschmidt@freebsd.org> Subject: Re: ifconfig meshforward command bug Message-ID: <CA%2BsBSoKaZpvXa7o8XCeQwjChDmPfP1Wx3tqi1AzphZW3Bi_wiA@mail.gmail.com> In-Reply-To: <CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com> References: <CA%2BsBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com> <201203221928.16271.bschmidt@freebsd.org> <CAJ-VmonJ5w-GpnkXqorqFJ%2BDcZqoR9kdoPkt9w9A-sXuQccodA@mail.gmail.com> <CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 22, 2012 at 7:56 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> On 22 March 2012 11:56, Adrian Chadd <adrian@freebsd.org> wrote:
>> On 22 March 2012 11:28, Bernhard Schmidt <bschmidt@freebsd.org> wrote:
>>
>>> Seems about right, those declared with DEF_CMD() should use d.
>>
>> Shall I commit this?
>
> .. a lot of these mesh functions use DECL_CMD_FUNC(), should they all
> be using d?
No I dont think all of them should use d. If you send a value like for
meshttl for example you should not use d, d is only for enable/disable
flags, for example this is CORRECT:
static
DECL_CMD_FUNC(set80211meshttl, val, d)
{
set80211(s, IEEE80211_IOC_MESH_TTL, atoi(val), 0, NULL);
}
br
>
>
> adrian
--
Monthadar Al Jaberi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BsBSoKaZpvXa7o8XCeQwjChDmPfP1Wx3tqi1AzphZW3Bi_wiA>