Date: Fri, 13 Jan 2017 18:19:37 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Julio Merino <jmmv@freebsd.org> Subject: Re: svn commit: r312103 - head/tests/sys/vfs Message-ID: <A00F5B9E-80BB-4C5C-BEEA-FD3902D6CC30@gmail.com> In-Reply-To: <73E9CEF8-F9B4-4108-9421-CD8A456BB32D@gmail.com> References: <201701140103.v0E13K8b068874@repo.freebsd.org> <07802033-D072-404C-8920-3E598C1C567F@gmail.com> <73E9CEF8-F9B4-4108-9421-CD8A456BB32D@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jan 13, 2017, at 17:07, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > >> On Jan 13, 2017, at 17:06, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: >> >>> >>> On Jan 13, 2017, at 17:03, Conrad E. Meyer <cem@FreeBSD.org> wrote: >>> >>> Author: cem >>> Date: Sat Jan 14 01:03:20 2017 >>> New Revision: 312103 >>> URL: https://svnweb.freebsd.org/changeset/base/312103 >>> >>> Log: >>> Revert r310994 >>> >>> Don't implement some terrible hack on a test by test basis. The >>> framework fix is straightforward and can be chased up in the original >>> bug. >>> >>> Reviewed by: ngie ("be my guest") >> >> You should have filed an issue with atf/kyua, had the fix done, then done the necessary parts in releasing a new port/package. Please disable the test because it doesn’t work at all right now on CURRENT and it will ping the sh’t out of the jenkins email until fixed. >> -Ngie > > PS Saying “be my guest” isn’t review in any shape or form, nor is it my consent towards your change being implemented now. Oh yeah… this commit broke the build too because I turned on WARNS: https://jenkins.freebsd.org/job/FreeBSD_HEAD_i386/4653/ Cheers, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYeYq6AAoJEPWDqSZpMIYV4UYQAI2ugY5zQzbQZydGNxZ2Sgfw vnmtZ8hougZEbRYrbQrLOYrY+sB0l0sCZ925l0dpVSosKBO2YQdwrutkFvUTpFk0 XjAbfc+s9M42oB6s3jB6krK9lUw70P4e9C9GAG0W14+q3RbeLXfUnay5ez5mz61W bn/ETmFhbZOEyXJ/m8VldyN2eYeig9JwMaPzV8C6TMl6Ez+2tH1OeUOYDFRhR186 M7UdLz8gVLUYENYypLOAbK+rhyO4x+jN8VDWQhpE3brSv5yflu76c9v/s+Xhz4nG UsRoiV8Z1TNrHpIRi9AhP/26wZtIWR4fInePv+Q9CgsNXQYErUasmA15F7g317iQ DDsEOsWLgWwaE56CiR59pAIf6ynxPOxIx6nKDCL+w5bwQHaz9UK1sWHubSr8ws9h DgODqmzcjRmkQVtkjQHLaeKaWAgDNYwBYPw9+xUD8qbn9wRmC3jWujX4QQ5RhnqE n+EV8i9hOZRc9ojneXNYyn3lDh5PEKdRv4Q4R/dycrAEBMjfHubH6zRwMHMwRP8s cBqJL81yDJ+9Vzph7romzEXXASMUU0pgSBo30ta8bhK2LGuR8Ghi3OTnmZX2C3RB L3XsxeIRgCtY8PSRoX7a2dFLYcckahHWvki2E7jGzu08tPIZoMSP3H1L7dqAbHiI oijHFccXKWU3BITJ1i1m =KTRg -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A00F5B9E-80BB-4C5C-BEEA-FD3902D6CC30>