Date: Mon, 25 Feb 2019 10:08:59 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Brooks Davis <brooks@freebsd.org>,Matt Macy <mmacy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov Message-ID: <A0EA59E1-7951-473D-8CEF-BAB18D69ECE4@cschubert.com> In-Reply-To: <20190225175809.GB47081@spindle.one-eyed-alien.net> References: <201902232114.x1NLE0cH085345@repo.freebsd.org> <20190225175809.GB47081@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On February 25, 2019 9:58:09 AM PST, Brooks Davis <brooks@freebsd.org> wrote: >On Sat, Feb 23, 2019 at 09:14:00PM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Sat Feb 23 21:14:00 2019 >> New Revision: 344487 >> URL: https://svnweb.freebsd.org/changeset/base/344487 >> >> Log: >> gcov support >> >> add gcov support and export results as files in debugfs > >We had a brief discussion of this commit within a subset of core. This >addition of GPLv2 code is fine as the code is easily removal to a >module >(per kmoore@) should the day come that we're read to evict all GPL >code. >The modest increase in activation energy for that task seems worth it >for the short-term gains of reduced integration cost (this code will >greatly improve our ZFS-on-Linux test coverage.) > >Rod rightly points out that we haven't accepted SPDX tags alone as >license statements. The standard GPL v2.0 boiler plate should be added >to this file along side the tag. > >An additional issue is that the a warning tag was not added to >sys/conf/files. A warning along the lines of: > > warning "kernel contains GPLv2 licensed GCOV" > >needs to be added. > >This commit needed more through review. > > >We intend to update our license policy to require core sign off for >new GPL code to ensure we're not adding new, tightly integrated >dependencies, to document that we're doing so knowingly, and >to make sure steps aren't missed. The current document is at: >https://www.freebsd.org/internal/software-license.html > >-- Brooks That's a excellent idea. I was thinking about suggesting that over the weekend (actually a committee, but core is better). -- Pardon the typos and autocorrect, small keyboard in use. Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A0EA59E1-7951-473D-8CEF-BAB18D69ECE4>