Date: Fri, 30 Dec 2016 14:00:55 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ngie Cooper <ngie@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310864 - head/sys/netinet Message-ID: <FBFBEFD4-EB79-408F-8A08-54748AB5854D@gmail.com> In-Reply-To: <320706A4-1CA3-4ECB-81F6-D29B9ECB15B9@gmail.com> References: <201612302133.uBULX1YA010091@repo.freebsd.org> <320706A4-1CA3-4ECB-81F6-D29B9ECB15B9@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Dec 30, 2016, at 13:53, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On Dec 30, 2016, at 13:33, Ngie Cooper <ngie@FreeBSD.org> wrote: >> >> Author: ngie >> Date: Fri Dec 30 21:33:01 2016 >> New Revision: 310864 >> URL: https://svnweb.freebsd.org/changeset/base/310864 >> >> Log: >> Unbreak ip_carp with WITHOUT_INET6 enabled by conditionalizing all IPv6 >> structs under the INET6 #ifdef. Similarly (even though it doesn't seem >> to affect the build), conditionalize all IPv4 structs under the INET >> #ifdef >> >> This also unbreaks the LINT-NOINET6 tinderbox target on amd64; I have not >> verified other MACHINE/TARGET pairs (e.g. armv6/arm). > > Quick note (mostly for myself): I’m running "make tinderbox” to address this concern and see if I can spot other issues. > Cheers, I realized looking at the code that unfortunately it’s still broken when both IPv4/IPv6 are disabled :/. -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYZtkXAAoJEPWDqSZpMIYVP0kQALq8Irx5jJPTt9MhlOxkUFUZ 6gF6efsTtzO1S5JFXjmRQRGGftleWOzD1j97eLZCxo9VHt7GOct3MbjBH+dFPNU3 NS/JXSfnsa3ilbU+wcyhgS9pr+4rhWbW26jCntJN42cEAiHX3ePkmWSVqkDAm/MM f4aWyLaRKMFhzYE832qgX/CALXwV2qMnxMAgT8f5jbSGK3GjsMQQEcQC3GLqU4VB e1KHEbqQIObfBy81+FLRnVrrotCJDq4AhYSBaM1eCg3owES1JWC3m65t8gAi+Pdj nAtr/oRl3A/3F/RHB+45BaCsiwq8tvjNlcCZbCSK293xO7f8HqiM0Sf67eUJoHHn QBbAFcSbdqUp50nguNGcMhbkBTqq+nkZ+lXSibsxo2gfanjBVlpZxzkLZyjpDEk0 qEGrIi4hTi9d5dRuYwxplF8VT1KJMWtKKM5A8jCjVgFmTqxelbfRiVc9Vq1cgG3+ if88PRm7kZe+4xRyrowT0ovM4gjCXtNwjtR8PMUsF9wMpn9fGFiBnO+7TGuYtetf FOVvmQoEIDO43xp/4qkXM2ej4K+YrzjrfAFzreDyFrch5hWuft+3ZYoCyABqY/kX 9M54hNFrWHIN2SOqNSnRX4Tfx07OcFZKNuW+EHlo8ImICxu2hZEM+wGZ19n3WOeF QVBwk7KEq2ck6wSxXNb2 =nHwR -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FBFBEFD4-EB79-408F-8A08-54748AB5854D>