Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Aug 2020 11:13:50 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Mateusz Guzik <mjguzik@gmail.com>, Jung-uk Kim <jkim@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm
Message-ID:  <7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel@freebsd.org>
In-Reply-To: <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com>
References:  <202008261655.07QGtSZx096979@repo.freebsd.org> <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2020-08-26 at 19:04 +0200, Mateusz Guzik wrote:
> On 8/26/20, Jung-uk Kim <jkim@freebsd.org> wrote:
> > Author: jkim
> > Date: Wed Aug 26 16:55:28 2020
> > New Revision: 364822
> > URL: https://svnweb.freebsd.org/changeset/base/364822
> > 
> > Log:
> >   Fix Clang version detection.
> > 
> >   We prepend "FreeBSD" to Clang version string.  This broke
> > compiler test
> > for
> >   AVX instruction support.
> > 
> 
> What about other software checking in similar fashion? imo the right
> fix is to stop mucking with the way clang reports itself
> 

Maybe it would be better to not modify the start of the string. 
Instead of 

FreeBSD clang version 9.0.1 (git@github.com:llvm/llvm-project.git
c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1)

maybe

clang version 9.0.1 for FreeBSD (git@github.com:llvm/llvm-project.git
c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1)

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel>