Date: Tue, 15 Mar 2016 04:56:39 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r296890 - head/sys/dev/mfi Message-ID: <201603150456.u2F4udoh075969@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Tue Mar 15 04:56:39 2016 New Revision: 296890 URL: https://svnweb.freebsd.org/changeset/base/296890 Log: Remove bare & 0x3; it encodes the values of BIO_READ and BIO_WRITE. It's also unnecessary since the only cases in this switch are those two. Modified: head/sys/dev/mfi/mfi.c Modified: head/sys/dev/mfi/mfi.c ============================================================================== --- head/sys/dev/mfi/mfi.c Tue Mar 15 04:42:37 2016 (r296889) +++ head/sys/dev/mfi/mfi.c Tue Mar 15 04:56:39 2016 (r296890) @@ -2141,7 +2141,7 @@ mfi_build_syspdio(struct mfi_softc *sc, pass = &cm->cm_frame->pass; bzero(pass->cdb, 16); pass->header.cmd = MFI_CMD_PD_SCSI_IO; - switch (bio->bio_cmd & 0x03) { + switch (bio->bio_cmd) { case BIO_READ: flags = MFI_CMD_DATAIN | MFI_CMD_BIO; readop = 1; @@ -2200,7 +2200,7 @@ mfi_build_ldio(struct mfi_softc *sc, str bzero(cm->cm_frame, sizeof(union mfi_frame)); cm->cm_frame->header.context = context; io = &cm->cm_frame->io; - switch (bio->bio_cmd & 0x03) { + switch (bio->bio_cmd) { case BIO_READ: io->header.cmd = MFI_CMD_LD_READ; flags = MFI_CMD_DATAIN | MFI_CMD_BIO;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603150456.u2F4udoh075969>