Date: Mon, 17 Feb 2003 07:30:41 +0100 From: phk@phk.freebsd.dk To: Marcel Moolenaar <marcel@xcllnt.net> Cc: current@FreeBSD.ORG Subject: Re: Console API related patch. Message-ID: <95188.1045463441@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 16 Feb 2003 16:04:10 PST." <20030217000410.GA769@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030217000410.GA769@dhcp01.pn.xcllnt.net>, Marcel Moolenaar writes: >> This patch changes the API so that rather than pass a "dev_t" to the >> console functions, the "struct consdev *" is passed: >> >> -typedef void cn_putc_t(dev_t, int); >> +typedef void cn_putc_t(struct consdev *, int); >> > >I like this. On the ia64 branch I completely ignore the dev argument >and instead use a static softc. The dev_t is unknown until after >bus enumeration in principle anyway. Yeah, I saw that. Actually I think more or less any console driver which uses the dev_t arg is wrong about doing that, but we can fix that subsequently. >I'll test ia64, both CVS an P4. Let me know when you like to >commit this so that I can schedule around that... I'm no no particular hurry, so whenever I have sufficient feedback to convince me that its safe. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95188.1045463441>