Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 11 Jun 2009 05:48:49 +0000 (UTC)
From:      Kip Macy <kmacy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r193973 - user/kmacy/releng_7_2_xen/sys/i386/xen
Message-ID:  <200906110548.n5B5mntQ037051@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kmacy
Date: Thu Jun 11 05:48:49 2009
New Revision: 193973
URL: http://svn.freebsd.org/changeset/base/193973

Log:
  Merge 193033
  
  Fix the Xen TOD update when the hypervisor wall clock is nudged.
  
   The "wall clock" in the current code is actually the hypervisor start time.
   The time of day is the "start time" plus the hypervisor "uptime".
  
   Large enough bumps in the dom0 clock lead to a hypervisor "bump" which is
   implemented as a bump in the start time, not the uptime. The clock.c routines
   were reading in the hypervisor start time and then using this as the TOD.
   This meant that any hypervisor time bump would cause the FreeBSD DomU to
   set its TOD to the hypervisor start time, rather than the actual TOD.
  
   This fix is a bit hacky and some reshuffling should be done later on
   to clarify what is going on. I've left the wall clock code alone.
   (The code which updates shadow_tv and shadow_tv_version.)
   A new routine adds the uptime to the shadow_tv, which is then used to
   update the TOD.
  
   I've included some debugging so it is obvious when the clock is nudged.

Modified:
  user/kmacy/releng_7_2_xen/sys/i386/xen/clock.c

Modified: user/kmacy/releng_7_2_xen/sys/i386/xen/clock.c
==============================================================================
--- user/kmacy/releng_7_2_xen/sys/i386/xen/clock.c	Thu Jun 11 05:47:13 2009	(r193972)
+++ user/kmacy/releng_7_2_xen/sys/i386/xen/clock.c	Thu Jun 11 05:48:49 2009	(r193973)
@@ -87,6 +87,7 @@ __FBSDID("$FreeBSD$");
 #include <machine/xen/xenfunc.h>
 #include <xen/interface/vcpu.h>
 #include <machine/cpu.h>
+#include <machine/xen/xen_clock_util.h>
 
 /*
  * 32-bit time_t's can't reach leap years before 1904 or after 2036, so we
@@ -237,6 +238,15 @@ static void update_wallclock(void)
 
 }
 
+static void
+add_uptime_to_wallclock(void)
+{
+	struct timespec ut;
+
+	xen_fetch_uptime(&ut);
+	timespecadd(&shadow_tv, &ut);
+}
+
 /*
  * Reads a consistent set of time-base values from Xen, into a shadow data
  * area. Must be called with the xtime_lock held for writing.
@@ -332,7 +342,9 @@ clkintr(void *arg)
 	 */
 	
 	if (shadow_tv_version != HYPERVISOR_shared_info->wc_version) {
+		printf("[XEN] hypervisor wallclock nudged; nudging TOD.\n");
 		update_wallclock();
+		add_uptime_to_wallclock();
 		tc_setclock(&shadow_tv);
 	}
 	
@@ -543,6 +555,7 @@ domu_inittodr(time_t base)
 	struct timespec ts;
 
 	update_wallclock();
+	add_uptime_to_wallclock();
 	
 	RTC_LOCK;
 	
@@ -592,6 +605,7 @@ domu_resettodr(void)
 		op.u.settime.system_time = shadow->system_timestamp;
 		HYPERVISOR_dom0_op(&op);
 		update_wallclock();
+		add_uptime_to_wallclock();
 	} else if (independent_wallclock) {
 		/* notyet */
 		;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906110548.n5B5mntQ037051>