Date: Tue, 4 Jun 2002 22:15:51 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: "Todd C. Miller" <Todd.Miller@courtesan.com> Cc: Bruce Evans <bde@zeta.org.au>, Alexander Leidinger <netchild@FreeBSD.ORG>, audit@FreeBSD.ORG Subject: Re: [PATCH] making dump EINTR resistant Message-ID: <p05111728b92323c754a3@[128.113.24.47]> In-Reply-To: <200206050110.g551Alpu020379@xerxes.courtesan.com> References: <20020605083335.T5376-100000@gamplex.bde.org> <p05111726b923006f0c07@[128.113.24.47]> <200206050110.g551Alpu020379@xerxes.courtesan.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At 7:10 PM -0600 6/4/02, Todd C. Miller wrote: >In message <p05111726b923006f0c07@[128.113.24.47]> > so spake Garance A Drosihn (drosih): > >> Would it be acceptable to add EINTR-type checks to freebsd-ish >> code? There are some sections of lpr/lpd which do not work >> right when compiled on other platforms, unless I add EINTR >> checks at the right places. > >It would probably be better to just make the code in question to >just use sigaction() if you are concerned about portability. That >way you get consistent handling of syscall restarts. > >Alternately, you could #define signal to bsd_signal when compiling >on non-BSD platforms. That is not quite as portable though. Ah. Actually I also wrote updates to use sigaction(), but I did that sometime after I had added the EINTR's around various system routines. It sounds like I shouldn't need the EINTR's anymore, but I just didn't realize it. I'll try going that route instead. That sounds much better. Thanks. (I'm still trying to unravel all the various updates I've added to lpr at RPI over the years...) -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05111728b92323c754a3>