Date: Tue, 27 Jul 1999 19:39:05 +0700 (NSS) From: "Nickolay N. Dudorov" <nnd@news.itfs.nsk.su> To: hackers@freebsd.org Subject: Re: replacing grep(1) Message-ID: <199907271239.TAA36462@news.itfs.nsk.su> In-Reply-To: <xzpd7xeb9xc.fsf@des.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In <xzpd7xeb9xc.fsf@des.follo.net> Dag-Erling Smorgrav <des@yes.no> wrote: > Jamie Howard (howardjp@wam.umd.edu), with a little help from yours > truly, has written a BSD-licensed version of grep(1) which has all the > functionality of our current (GPLed) implementation, plus a little > more, in one seventh the source code and one fourth the binary code. > What's more, the code is actually possible for mere mortals to read > and understand. > The source code is available for download from freefall: > <URL:http://www.freebsd.org/~des/software/grep-0.7.tar.gz> > I move that we replace GNU grep in our source tree with this > implementation, once it's been reviewed by all concerned parties. Unfortunately abovementioned grep-0.7.tar.gz is broken. After making it on the CURRENT system I can only see: grep: filename: Undefined error: 0 for every filename. This caused by very "unusual" return values for 'grep_open' (and other '..._open') function which is declared as 'int' (and return int result) and compared with NULL ;-( I prefer not to include the patch for this because I am uncompatible with such trics as: return ((f = fopen(path, mode)) != NULL) - 1; N.Dudorov To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907271239.TAA36462>