Date: Sun, 23 Sep 2018 14:15:22 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: amdmi3@freebsd.org, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r480462 - head/devel/p5-DateTime-Format-ICal Message-ID: <worc-o1et-wny@FreeBSD.org> In-Reply-To: <CAMHz58Q6ME1k7fPyrSmtmnM0zE6jJc==xE1JwUdpV7hOyzY%2BRw@mail.gmail.com> (Po-Chuan Hsieh's message of "Sun, 23 Sep 2018 17:24:46 %2B0800") References: <201809230908.w8N98RkZ018259@repo.freebsd.org> <CAMHz58Q6ME1k7fPyrSmtmnM0zE6jJc==xE1JwUdpV7hOyzY%2BRw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Po-Chuan Hsieh <sunpoet@freebsd.org> writes: > On Sun, Sep 23, 2018 at 5:08 PM Dmitry Marakasov <amdmi3@freebsd.org> wrote: > >> Author: amdmi3 >> Date: Sun Sep 23 09:08:27 2018 >> New Revision: 480462 >> URL: https://svnweb.freebsd.org/changeset/ports/480462 >> >> Log: >> - Add LICENSE >> - Fix depends >> > > I did not see any dependency change in this commit. Before this commit BUILD_DEPENDS had lang/perl5* listed more than once. ;) > According to mat's commit (r474242), the original one is preferred. Porter's Handbook recommends MY_DEPENDS, not BUILD_DEPENDS=${RUN_DEPENDS}. If you treat PH as rulebook (like portmgr often likes to do) then mat's commit was incorrect as well. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-run_depends Unfortunately, Porter's Handbook fails short of explaining why := is wrong. Even if a port uses RUN_DEPENDS:=${BUILD_DEPENDS} then Mk/* can still append to RUN_DEPENDS but anything appended to BUILD_DEPENDS doesn't propagate to RUN_DEPENDS which is intended. Not to mention, forbidding to use := in *_DEPENDS but not anywhere else seems odd.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?worc-o1et-wny>