Date: Tue, 13 Nov 2001 20:39:10 -0800 (PST) From: KOIE Hidetaka <koie@suri.co.jp> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/31966: `offset == dh->dh_seqopt' in ufsdirhash_lookup() is wrong? Message-ID: <200111140439.fAE4dAD14339@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 31966
>Category: kern
>Synopsis: `offset == dh->dh_seqopt' in ufsdirhash_lookup() is wrong?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 13 20:40:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator: KOIE Hidetaka
>Release: NONE
>Organization:
SURIGIKEN
>Environment:
NONE
>Description:
I'm not using FreeBSD.
I'm reading DIRHASH codes to study. I'm looking ufs_dirhash.c rev 1.6.
The function ufsdirhash_lookup() has `Sequential access optimisation'.
I suppose that
for (i = slot; (offset = DH_ENTRY(dh, i)) != DIRHASH_EMPTY;
i = WRAPINCR(i, dh->dh_hlen))
if (offset == dh->dh_seqopt)
break;
if (offset == dh->dh_seqoff) {
slot = i;
} else
dh->dh_seqopt = 0;
}
should be
...
if (offset == dh->dh_seqoff)
break;
...
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111140439.fAE4dAD14339>