Date: Fri, 27 Aug 2004 23:30:16 +0200 From: Andre Oppermann <andre@freebsd.org> To: freebsd-current@freebsd.org Subject: [Fwd: cvs commit: src/sys/kern sys_generic.c] Message-ID: <412FA7E8.80BE87BC@freebsd.org>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------ED0FEC6B74B8DFCDF715C0C2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Maybe this fixes poll() problems/errors some people have seen on their
machines. I am not sure if this alignment would have caused problems
on non-ia32 architectures but it is certainly more correct now. ;-)
--
Andre
--------------ED0FEC6B74B8DFCDF715C0C2
Content-Type: message/rfc822
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Return-Path: <owner-src-committers@FreeBSD.org>
Delivered-To: andre@networx.ch
Received: (qmail 60451 invoked from network); 27 Aug 2004 21:22:31 -0000
Received: from mx2.freebsd.org ([216.136.204.119])
(envelope-sender <owner-src-committers@FreeBSD.org>)
by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
for <andre@networx.ch>; 27 Aug 2004 21:22:31 -0000
Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])
by mx2.freebsd.org (Postfix) with ESMTP id 65F98559CB
for <andre@networx.ch>; Fri, 27 Aug 2004 21:23:52 +0000 (GMT)
(envelope-from owner-src-committers@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
id 1D79E16A4D6; Fri, 27 Aug 2004 21:23:52 +0000 (GMT)
Delivered-To: andre@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 538)
id F140F16A4D0; Fri, 27 Aug 2004 21:23:51 +0000 (GMT)
Delivered-To: src-committers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP
id C644616A4CE; Fri, 27 Aug 2004 21:23:50 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
by mx1.FreeBSD.org (Postfix) with ESMTP
id A46C043D41; Fri, 27 Aug 2004 21:23:50 +0000 (GMT)
(envelope-from andre@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i7RLNolK076003;
Fri, 27 Aug 2004 21:23:50 GMT
(envelope-from andre@repoman.freebsd.org)
Received: (from andre@localhost)
by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i7RLNoG5076002;
Fri, 27 Aug 2004 21:23:50 GMT
(envelope-from andre)
Message-Id: <200408272123.i7RLNoG5076002@repoman.freebsd.org>
From: Andre Oppermann <andre@FreeBSD.org>
Date: Fri, 27 Aug 2004 21:23:50 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/kern sys_generic.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-src-committers@FreeBSD.org
Precedence: bulk
X-Loop: FreeBSD.ORG
X-Mozilla-Status2: 00000000
andre 2004-08-27 21:23:50 UTC
FreeBSD src repository
Modified files:
sys/kern sys_generic.c
Log:
Poll() uses the array smallbits that is big enough to hold 32 struct
pollfd's to avoid calling malloc() on small numbers of fd's. Because
smalltype's members have type char, its address might be misaligned
for a struct pollfd. Change the array of char to an array of struct
pollfd.
PR: kern/58214
Submitted by: Stefan Farfeleder <stefan@fafoe.narf.at>
Reviewed by: bde (a long time ago)
MFC after: 3 days
Revision Changes Path
1.133 +3 -3 src/sys/kern/sys_generic.c
--------------ED0FEC6B74B8DFCDF715C0C2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?412FA7E8.80BE87BC>