Date: Wed, 20 Apr 2005 20:32:50 +0200 From: Miguel Mendez <flynn@energyhq.es.eu.org> To: "Jeremy Messenger" <mezz7@cox.net> Cc: gnome@freebsd.org Subject: Re: Can somebody please have a look at ports/78931? Message-ID: <20050420203250.597f6ae8.flynn@energyhq.es.eu.org> In-Reply-To: <op.spjl56u59aq2h7@mezz.mezzweb.com> References: <20050420194825.76ebf3c0.flynn@energyhq.es.eu.org> <op.spjl56u59aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Wed__20_Apr_2005_20_32_50_+0200_a0CQv7U7OT+SeLOP Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 20 Apr 2005 13:11:56 -0500 "Jeremy Messenger" <mezz7@cox.net> wrote: > Not useful to me, but it's up to someone in my team if he likes OPTIONS = =20 > stuff. Anyway, I took a bit look at it and I don't think few knobs will = =20 Could you elaborate on why you don't think OPTIONS are useful? I'm honestly interested. > work because of the OPTIONS don't work with the autocheck very well. I =20 > only see useful in your PR is that two knobs that have exist() should be = =20 > move under .include <bsd.port.pre.mk> and change DATADIR in plist. I did test builds with BATCH=3Dyes and it worked fine. If there's anything wrong I'd love to know about it. To make it clear: Whether the consensus is to get it in the tree or drop it, it's fine. What I'd like to avoid is to have the PR sitting in limbo for months. Cheers, --=20 Miguel Mendez <flynn@energyhq.es.eu.org> http://www.energyhq.es.eu.org PGP Key: 0xDC8514F1 --Signature=_Wed__20_Apr_2005_20_32_50_+0200_a0CQv7U7OT+SeLOP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCZqBVnLctrNyFFPERAnTSAJwKc7yuV4GjV8Z1qnpSw96PxWyXSQCfaD9e hrp1ZiWy/60wE5+ubiErYl4= =QznT -----END PGP SIGNATURE----- --Signature=_Wed__20_Apr_2005_20_32_50_+0200_a0CQv7U7OT+SeLOP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050420203250.597f6ae8.flynn>