Date: Tue, 5 Nov 2024 02:11:58 GMT From: Jose Luis Duran <jlduran@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 9e84289f2c7e - main - git-arc: Prefer echo over printf Message-ID: <202411050211.4A52Bwbo019997@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=9e84289f2c7e6b632047a75b653fcd587287a8b9 commit 9e84289f2c7e6b632047a75b653fcd587287a8b9 Author: Jose Luis Duran <jlduran@FreeBSD.org> AuthorDate: 2024-11-05 01:13:22 +0000 Commit: Jose Luis Duran <jlduran@FreeBSD.org> CommitDate: 2024-11-05 02:10:16 +0000 git-arc: Prefer echo over printf Prefer echo over printf. Prevent the newline character from being translated by using 'blank' instead of 'space' in the re_format. This change was reviewed in: https://reviews.freebsd.org/D47289 Committed separately for clarity. Suggested by: des Approved by: emaste (mentor) --- tools/tools/git/git-arc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tools/git/git-arc.sh b/tools/tools/git/git-arc.sh index 64d1ee2bd63f..050ec4ec1f2c 100644 --- a/tools/tools/git/git-arc.sh +++ b/tools/tools/git/git-arc.sh @@ -341,7 +341,7 @@ diff2reviewers() jq '.response.data[0].attachments.reviewers.reviewers[] | select(.status == "accepted").reviewerPHID') if [ -n "$userids" ]; then echo '{ - "constraints": {"phids": ['"$(printf "%s" "$userids" | tr '[:space:]' ',')"']} + "constraints": {"phids": ['"$(echo "$userids" | tr '[:blank:]' ',')"']} }' | arc_call_conduit -- user.search | jq -r '.response.data[].fields.username'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202411050211.4A52Bwbo019997>