Date: Sun, 12 Sep 2004 04:37:41 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71619: [PATCH] cleanup of the usr.sbin/tcpdump code Message-ID: <200409120237.i8C2bfRG007098@kulesh.obluda.cz> Resent-Message-ID: <200409120240.i8C2eO8L086969@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71619
>Category: bin
>Synopsis: [PATCH] cleanup of the usr.sbin/tcpdump code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 12 02:40:24 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/tcpdump/tcpslice/tcpslice.c,v 1.12 2002/01/19 23:20:02 dillon
usr.sbin/tcpdump/tcpslice/gwtm2secs.c,v 1.4 1999/08/28 05:11:32 peter
>Description:
There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.
Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.
I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.
usr.sbin/tcpdump/tcpslice/gwtm2secs.c:49: warning: suggest explicit braces to avoid ambiguous `else'
usr.sbin/tcpdump/tcpslice/tcpslice.c:198: warning: implicit declaration of function `_long_to_time'
>How-To-Repeat:
N/A
>Fix:
*** usr.sbin/tcpdump/gwtm2secs.c.ORIG Mon Sep 6 11:13:34 2004
--- usr.sbin/tcpdump/gwtm2secs.c Mon Sep 6 11:14:33 2004
***************
*** 46,56 ****
* 2-digit years are either 19xx or 20xx - a simple heuristic
* distinguishes them, since we can't represent any time < 1970.
*/
! if ( year < 100 )
if ( year >= 70 )
year += 1900;
else
year += 2000;
days = 0;
for ( i = 1970; i < year; ++i )
--- 46,58 ----
* 2-digit years are either 19xx or 20xx - a simple heuristic
* distinguishes them, since we can't represent any time < 1970.
*/
! if ( year < 100 )
! {
if ( year >= 70 )
year += 1900;
else
year += 2000;
+ }
days = 0;
for ( i = 1970; i < year; ++i )
*** usr.sbin/tcpdump/tcpslice.c.ORIG Sun Jan 20 00:20:02 2002
--- usr.sbin/tcpdump/tcpslice.c Mon Sep 6 11:20:36 2004
***************
*** 35,40 ****
--- 35,41 ----
*/
#include <err.h>
+ #include <timeconv.h>
#include "tcpslice.h"
int tflag = 0; /* global that util routines are sensitive to */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409120237.i8C2bfRG007098>