Date: Sat, 09 Nov 2019 20:49:58 +0100 From: Alexander Leidinger <Alexander@leidinger.net> To: Edward Tomasz Napierala <trasz@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354458 - head/libexec/rc/rc.d Message-ID: <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net> In-Reply-To: <201911071815.xA7IFOhI070066@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Quoting Edward Tomasz Napierala <trasz@freebsd.org> (from Thu, 7 Nov 2019 18:15:24 +0000 (UTC)): > Author: trasz > Date: Thu Nov 7 18:15:24 2019 > New Revision: 354458 > URL: https://svnweb.freebsd.org/changeset/base/354458 > > Log: > Extend the linux rc script to mount the neccessary file systems, > set ELF fallback brand, and load pty(4). We never did something like that. We have it documented everywhere that it needs to be done manually. So this is at least a POLA violation. It is great that the nocover option is used in the mount, but it's still some kind of layering violation (I may want to have only a subset mounted, or nothing at all). I do not object to the functionality, but I think it needs to be configurable (an option to influence if the auto-mount is done or not, doesn't matter to me what the default behavior is, as long as it is configurable) and documented (UPDATING, handbook, man-pages, maybe even the release notes). Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJdxxhmAAoJEBINsJsD+NiGlFIP/2IHcnBe5tDBtAcisS/HONgw Qrbwweqcsf2THYewkCIXt36e6G5iq3vVgP9quQ3ZHVba3KauP83mg2a7BR0JsC7W R8fOE9AVQ4R4NNg8p6qqhfMVIMUCSDWhkfuDYYkfKiaiQezZHXp39YfkvM1aFcsV 5gqcP/upbZ1YDE0GrfuZhwn78ulbFJYVi6ysgdk+XRPzIp8jkvX2Rqjp/zpxFAxY OZvazCOFH4+Kj3wPmpkZ4G7ZbwQ5itWXr/g2KP3M2u+SYuxolEf/hMD+WEcHQqr1 zJ+xB3XQSjeqwipuKRf3Y5BFzEMLBu8QMDATO+nawv3BMvAHSQYy2OHSjfLG8hq/ xV/8RBysjJfyqXiFfM2GACsyo/x1FsxrmOYry7hpsxrrl/zi5wFeyeQMZ2GhGNos iWXvnoSAHH1XB3fy4fM8+5hbcj1ELP7Pa1eygY0ewM6bqOC0xL1Cg6hBcXj4UIUa +UeKmywvJBtcnmRVFoqigvO/hFkE4GYgboVJEk67zX9JkEX272A4gOsEk0/o8NwK HSmdAPUJICEFv9xehf6hZ6OrKoxr5CgcBxYxQuNk3gwuz0KCDDFNsQ/1IBfQF8Hj 6PFOOkz7UDV2FKD9u5WpDoW6f7ccZn5ObTHt4AAbngQp6WSXqmige3bB8l6iHB+8 uIdgQDqoad9UGLzRMAtU =6vFC -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt>