Date: Fri, 25 May 2018 15:25:18 -0600 From: Ian Lepore <ian@freebsd.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, Brad Davis <brd@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333407 - head/share/mk Message-ID: <1527283518.32688.164.camel@freebsd.org> In-Reply-To: <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org> References: <201805091344.w49Dist5061908@repo.freebsd.org> <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2018-05-25 at 14:10 -0700, Bryan Drewery wrote: > On 5/9/2018 6:44 AM, Brad Davis wrote: > > > > Author: brd > > Date: Wed May 9 13:44:54 2018 > > New Revision: 333407 > > URL: https://svnweb.freebsd.org/changeset/base/333407 > > > > Log: > > Enable directory creation with FILESDIR. > > > > This is part of packaging base work. > > > > Reviewed by: will > > Approved by: bapt (mentor), allanjude (mentor) > > Differential Revision: https://reviews.freebsd.org/D15130 > > > Please update share/mk/bsd.README too. > > I know I haven't been very responsive but it's partly because I'm still > fundamentally against this feature. It's adding a mechanism to replace > mtree without considering the whole picture and only binding it to FILES > rather than a bsd.dirs.mk; It doesn't actually satisfy replacing mtree > files since it only works if there is a FILESGROUP used (FILES must be > non-empty). So what's the point? My major concern is added confusion. > The creation of directories for installing is a pain point at work for > developers but I don't think this is enough. I liked the idea of > `install "-D"` but I know it's not efficient and had some implementation > issues. I welcome this work. If it's not complete/perfect, we can iterate towards that, but mtree is not a good solution for out-of-tree builds that use the build machinery in /usr/share/mk. The lack of a solution other than mtree has led to half a dozen different hacks scattered around the makefiles in our application repo, and it's about time this hole in the build system gets plugged. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1527283518.32688.164.camel>