Date: Sat, 10 Oct 2009 22:17:03 +0000 (UTC) From: Doug Barton <dougb@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/etc rc.subr src/etc/rc.d bgfsck cleartmp faith fsck hostid hostname ldconfig motd mountcritlocal moused netif newsyslog nfsclient pf savecore stf Message-ID: <200910102221.n9AMLUsH007499@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
dougb 2009-10-10 22:17:03 UTC FreeBSD src repository Modified files: etc rc.subr etc/rc.d bgfsck cleartmp faith fsck hostid hostname ldconfig motd mountcritlocal moused netif newsyslog nfsclient pf savecore stf Log: SVN rev 197947 on 2009-10-10 22:17:03Z by dougb In regards to the "Starting foo:" type messages at boot time, create and employ a more generic solution, and use it in the individual rc.d scripts that also have an $rc_quiet test: 1. Add check_startmsgs() to rc.subr. 2. In the rc.d scripts that use rc_quiet (and rc.subr) substitute variations of [ -z "$rc_quiet" ] with check_startmsgs 3. In savecore add a trailing '.' to the end of the message to make it more consistent with other scripts. 4. In newsyslog remove a : before the terminal '.' since we do not expect there to be anything printed out in between to make it more consistent. 5. In the following scripts change "quotes" to 'quotes' where no variables exist in the message: savecore pf newsyslog 6. In the following scripts substitute if/then/fi for the simpler (and more consistent) check_startmsgs &&: faith stf 7. In the following scripts separate the "Starting foo:" from the terminal '.' to make them more consistent: moused hostname pf 8. In nfsclient move the message to its own line to avoid a style bug 9. In pf rc_quiet does not apply to the _stop method, so remove the test there. 10. In motd add 'quotes' around the terminal '.' for consistency Revision Changes Path 1.10 +1 -1 src/etc/rc.d/bgfsck 1.20 +2 -2 src/etc/rc.d/cleartmp 1.4 +1 -3 src/etc/rc.d/faith 1.15 +1 -1 src/etc/rc.d/fsck 1.12 +2 -2 src/etc/rc.d/hostid 1.14 +2 -1 src/etc/rc.d/hostname 1.21 +3 -4 src/etc/rc.d/ldconfig 1.12 +2 -2 src/etc/rc.d/motd 1.18 +2 -2 src/etc/rc.d/mountcritlocal 1.16 +2 -1 src/etc/rc.d/moused 1.35 +1 -1 src/etc/rc.d/netif 1.8 +2 -2 src/etc/rc.d/newsyslog 1.8 +2 -1 src/etc/rc.d/nfsclient 1.20 +4 -2 src/etc/rc.d/pf 1.17 +1 -1 src/etc/rc.d/savecore 1.4 +2 -3 src/etc/rc.d/stf 1.92 +15 -7 src/etc/rc.subr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910102221.n9AMLUsH007499>