Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 22 Nov 2025 14:31:04 +0000
From:      Andrew Gallatin <gallatin@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: cfad68c5c6b9 - main - igc: use newly exposed RSS hash key API rather than ad-hoc hashing
Message-ID:  <6921c928.30924.22d94024@gitrepo.freebsd.org>
index | next in thread | raw e-mail 

The branch main has been updated by gallatin:

URL: https://cgit.FreeBSD.org/src/commit/?id=cfad68c5c6b9c1a203b3c3777e252048df92281d

commit cfad68c5c6b9c1a203b3c3777e252048df92281d
Author:     Andrew Gallatin <gallatin@FreeBSD.org>
AuthorDate: 2025-11-22 14:29:35 +0000
Commit:     Andrew Gallatin <gallatin@FreeBSD.org>
CommitDate: 2025-11-22 14:29:35 +0000

    igc: use newly exposed RSS hash key API rather than ad-hoc hashing
    
    Differential Revision:  https://reviews.freebsd.org/D53103
    Reviewed by: markj
    Sponsored by: Netflix
---
 sys/dev/igc/if_igc.c   | 7 +------
 sys/dev/igc/igc_txrx.c | 2 --
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c
index d6c06803990f..a4e5de2ae82a 100644
--- a/sys/dev/igc/if_igc.c
+++ b/sys/dev/igc/if_igc.c
@@ -32,10 +32,9 @@
 #include <sys/sbuf.h>
 #include <machine/_inttypes.h>
 
-#ifdef RSS
 #include <net/rss_config.h>
 #include <netinet/in_rss.h>
-#endif
+
 
 /*********************************************************************
  *  PCI Device ID Table
@@ -1940,12 +1939,8 @@ igc_initialize_rss_mapping(struct igc_softc *sc)
 	 */
 	mrqc = IGC_MRQC_ENABLE_RSS_4Q;
 
-#ifdef RSS
 	/* XXX ew typecasting */
 	rss_getkey((uint8_t *) &rss_key);
-#else
-	arc4rand(&rss_key, sizeof(rss_key), 0);
-#endif
 	for (i = 0; i < RSSKEYLEN; i++)
 		IGC_WRITE_REG_ARRAY(hw, IGC_RSSRK(0), i, rss_key[i]);
 
diff --git a/sys/dev/igc/igc_txrx.c b/sys/dev/igc/igc_txrx.c
index 92ba81c79c58..96949492fd24 100644
--- a/sys/dev/igc/igc_txrx.c
+++ b/sys/dev/igc/igc_txrx.c
@@ -30,10 +30,8 @@
 #include <sys/cdefs.h>
 #include "if_igc.h"
 
-#ifdef RSS
 #include <net/rss_config.h>
 #include <netinet/in_rss.h>
-#endif
 
 #ifdef VERBOSE_DEBUG
 #define DPRINTF device_printf
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6921c928.30924.22d94024>