Date: Sun, 19 Jul 2009 19:28:10 +0200 From: "Paul B. Mahol" <onemda@gmail.com> To: current@freebsd.org Cc: net@freebsd.org Subject: Re: ndis lor: hal preemption lock Message-ID: <3a142e750907191028u15dfd769o26270d48d15ae664@mail.gmail.com> In-Reply-To: <3a142e750907150027t106edef5m767dd0319f83bd63@mail.gmail.com> References: <3a142e750906080809i381c4e6amd93da8a135ab9bd3@mail.gmail.com> <1244477453.7794.2.camel@localhost> <3a142e750906081006v6369051dw75c5077e6032101f@mail.gmail.com> <1244656248.1701.53.camel@localhost> <3a142e750906101108v588e33dfsb0cb81f024c65cfb@mail.gmail.com> <1244658479.1701.56.camel@localhost> <3a142e750906101805re85136cif71eeeda2c641451@mail.gmail.com> <1245323702.1754.0.camel@localhost> <3a142e750907040333o3938c06y6369af6fa6976812@mail.gmail.com> <3a142e750907150027t106edef5m767dd0319f83bd63@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/15/09, Paul B. Mahol <onemda@gmail.com> wrote:
> On 7/4/09, Paul B. Mahol <onemda@gmail.com> wrote:
>> On 6/18/09, Coleman Kane <cokane@freebsd.org> wrote:
>>> I've committed this one as r194432.
>>
>> Ah, that one introduced regression.
>> Switching ndisX up before creating vap will cause panic.
>> Here is fix:
>>
>> --- /sys/dev/if_ndis/if_ndis.c 2009-06-28 09:15:54.000000000 +0000
>> +++ if_ndis.c 2009-07-04 10:23:41.000000000 +0000
>> @@ -2292,6 +2292,8 @@
>> ifp = sc->ifp;
>> ic = ifp->if_l2com;
>> vap = TAILQ_FIRST(&ic->ic_vaps);
>> + if (vap == NULL)
>> + return;
>>
>> if (!NDIS_INITIALIZED(sc)) {
>> DPRINTF(("%s: NDIS not initialized\n", __func__));
>
> Bump!
>
> Please commit.
Beep!
kern/136895
--
Paul
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a142e750907191028u15dfd769o26270d48d15ae664>