Date: Sun, 30 Aug 2009 20:40:07 +0800 From: Eugene Grosbein <eugen@kuzbass.ru> To: Marc Fonvieille <blackend@FreeBSD.org> Cc: stable@freebd.org, FreeBSD-gnats-submit@FreeBSD.org, qa@FreeBSD.org Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module Message-ID: <20090830124006.GA67685@svzserv.kemerovo.su> In-Reply-To: <20090830123408.GC1306@gothic.blackend.org> References: <200908301123.n7UBN6M7001670@kuzbass.ru> <20090830123408.GC1306@gothic.blackend.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 30, 2009 at 02:34:08PM +0200, Marc Fonvieille wrote:
> > ===> sys/modules/sysvipc/sysvmsg (depend)
> > machine -> /usr/local/src/sys/i386/include
> > :> opt_sysvipc.h
> > @ -> /usr/local/src/sys
> > rm -f .depend
> > mkdep -f .depend -a -nostdinc -D_KERNEL -DKLD_MODULE -I. -I@ -I@/contrib/altq /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c
> > /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c:53:24: error: opt_compat.h: No such file or directory
> > mkdep: compile failed
> > *** Error code 1
> >
> > >How-To-Repeat:
> > Try to build NanoBSD.
> >
> > >Fix:
> >
> > Apply next patch to /usr/src:
> >
> > --- sys/modules/sysvipc/sysvmsg/Makefile.orig 2009-08-30 19:12:16.000000000 +0800
> > +++ sys/modules/sysvipc/sysvmsg/Makefile 2009-08-30 19:14:13.000000000 +0800
> > @@ -5,4 +5,11 @@
> > KMOD= sysvmsg
> > SRCS= sysv_msg.c opt_sysvipc.h
> >
> > +.if !defined(KERNBUILDDIR)
> > +opt_compat.h:
> > + echo "#define COMPAT_FREEBSD8 1" > ${.TARGET}
> > +
> > +SRCS+= opt_compat.h
> > +.endif
> > +
> > .include <bsd.kmod.mk>
> >
> >
>
> I suspect it's the problem I met when I tried to do a
>
> make -DMODULES_WITH_WORLD="YES" buildworld
>
> and many modules were concerned. See the following patch:
>
> Index: sys/modules/dtrace/lockstat/Makefile
> ===================================================================
> --- sys/modules/dtrace/lockstat/Makefile (revision 196013)
> +++ sys/modules/dtrace/lockstat/Makefile (working copy)
> @@ -5,7 +5,7 @@
> KMOD= lockstat
> SRCS= lockstat.c
>
> -SRCS+= vnode_if.h
> +SRCS+= vnode_if.h opt_kdtrace.h
>
> CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
> -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
> Index: sys/modules/sysvipc/sysvsem/Makefile
> ===================================================================
> --- sys/modules/sysvipc/sysvsem/Makefile (revision 196013)
> +++ sys/modules/sysvipc/sysvsem/Makefile (working copy)
> @@ -3,6 +3,6 @@
> .PATH: ${.CURDIR}/../../../kern
>
> KMOD= sysvsem
> -SRCS= sysv_sem.c opt_sysvipc.h
> +SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
>
> .include <bsd.kmod.mk>
> Index: sys/modules/sysvipc/sysvmsg/Makefile
> ===================================================================
> --- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013)
> +++ sys/modules/sysvipc/sysvmsg/Makefile (working copy)
> @@ -3,6 +3,6 @@
> .PATH: ${.CURDIR}/../../../kern
>
> KMOD= sysvmsg
> -SRCS= sysv_msg.c opt_sysvipc.h
> +SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
>
> .include <bsd.kmod.mk>
>
You are right, other modules are concerned and your patch is more complete
and correct. Vote for commit :-)
Eugene Grosbein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090830124006.GA67685>